-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MADS - digitaltwin core module tests #175
Open
LukeParky
wants to merge
4
commits into
GeospatialResearch:master
Choose a base branch
from
GeospatialResearch:test_digitaltwin
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
MADS - digitaltwin core module tests #175
LukeParky
wants to merge
4
commits into
GeospatialResearch:master
from
GeospatialResearch:test_digitaltwin
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
36c0b5b
to
803f987
Compare
|
803f987
to
4f135ed
Compare
Hi @caseyli92, before I finish my review, I want to check it over with your new linting. I'm going to block this against your linting issue |
Status: Ready to merge ✔️Issues blocking this PR:This comment was automatically written by the Blocking Issues bot, and this PR will be monitored for further progress. |
4f135ed
to
ba1a9e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of work done by MADs students. Opening a PR to investigate getting this into the core upstream repo.
Original PR: GeospatialResearch#2
Blocked by: #159 - I expect linting errors to occur