Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support FOR_MIGRATION InternalRange objects #11856

Merged
merged 6 commits into from
Oct 4, 2024

Conversation

sebkalis
Copy link
Contributor

@sebkalis sebkalis commented Sep 27, 2024

Support for for-migration InternalRange resources.

A new value of usage enum is introduced: FOR_MIGRATION. Such ranges must also contain a nested object consisting of 2 strings: source - an URI/path to the migration source (a subnet resource being migrated, in its original location) and a target - an URI/path for the planned future resource (a subnet) to be recreated in the new location.

Fixes hashicorp/terraform-provider-google#19636

Release Note Template for Downstream PRs (will be copied)

networkconnectivity: added field `migration` to resource `google_network_connectivity_internal_range`

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@ScottSuarez
Copy link
Contributor

Could you add a test for this field and pull the latest changes from main?

Copy link

github-actions bot commented Oct 2, 2024

@ScottSuarez This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Contributor

@ScottSuarez ScottSuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for addition of test

@github-actions github-actions bot requested a review from ScottSuarez October 4, 2024 10:57
@sebkalis
Copy link
Contributor Author

sebkalis commented Oct 4, 2024

Test has been added

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 211 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 3 files changed, 211 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 40 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 128 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 25
Passed tests: 23
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages
  • networkconnectivity

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesMigrationExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesMigrationExample[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@sebkalis
Copy link
Contributor Author

sebkalis commented Oct 4, 2024

waiting for addition of test

Done

Copy link
Contributor

@ScottSuarez ScottSuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work ! 😄

@ScottSuarez ScottSuarez merged commit b667593 into GoogleCloudPlatform:main Oct 4, 2024
14 checks passed
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Oct 7, 2024
trodge pushed a commit to trodge/magic-modules that referenced this pull request Oct 10, 2024
karolgorc pushed a commit to karolgorc/magic-modules that referenced this pull request Oct 11, 2024
gontech pushed a commit to gontech/magic-modules that referenced this pull request Oct 16, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 23, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 24, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for usage=FOR_MIGRATION InternalRange resources to networkconnectivity product
3 participants