Add plan-time validation of name on google_compute_instance

[karolgorc]

closes hashicorp/terraform-provider-google#18265

• Added name validation to google_compute_instance

The regexes are wrong in the validation file. Our verification functions expected 2-63 characters when in reality it's 1-63. Basing on this documentation: https://cloud.google.com/compute/docs/naming-resources#resource-name-format and manual testing

Some other tests might fail due to these changes in the validate file so pls paste the test errors after the CICD run

Release Note Template for Downstream PRs (will be copied)

compute: added plan-time validation to `name` on `google_compute_instance`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[github-actions]

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[rileykarson]

This allows the string "a" when any input is supplied. For example, 1,61 (source input to the fn of 2,63). Added some extra test cases as constraints.

I suspect we need to rework the regex substantially to go below a minimum of 2 while properly validating the format. We may want to mix procedural code and regex or just write this as entirely procedural code.

[karolgorc]

agreed. After checking this regex fails on one new test case that you've added. This is mainly due to length which should be procedural imo.

The only other think that this regex is affecting are Service Account names so will look out for errors there as well.

[karolgorc]

sorry. Pushed a rebased branch on accident.

What was done.

• added new test cases
• The function now validates the length outside of the regex.
• The variable with the regex takes in one string value instead of 2 ints

RFC1035NameTemplate = "[a-z]([-a-z0-9]%v[a-z0-9])?"

This allows to input a "*" wildcard for our case but also can take "{4,28}" as input not to break the existing ServiceAccount regexes. Because they specify length in the regex while we do it through the function.

Here are 2 unit tests affected

=== RUN   TestValidateRFC1035Name
--- PASS: TestValidateRFC1035Name (0.00s)

=== RUN   TestValidateServiceAccountLink
--- PASS: TestValidateServiceAccountLink (0.00s)

[github-actions]

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google-beta provider: Diff ( 3 files changed, 34 insertions(+), 19 deletions(-))

Errors

google provider:

• Failed to build branch auto-pr-11886-old

[modular-magician]

Tests analytics

Total tests: 4196
Passed tests: 3776
Skipped tests: 418
Affected tests: 2

Click here to see the affected service packages

All service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample
• TestAccDataLossPreventionDiscoveryConfig_Update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample[Debug log]
TestAccDataLossPreventionDiscoveryConfig_Update[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[karolgorc]

==> Checking that code complies with gofmt requirements...
gofmt needs running on the following files:
./google/services/sql/resource_sql_database_test.go
You can use the command: `make fmt` to reformat code.
make: *** [GNUmakefile:26: fmtcheck] Error 1

doesn't seem related

[github-actions]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.