-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix how conditions are handled in google_bigtable_instance_iam_*
resources
#11890
Fix how conditions are handled in google_bigtable_instance_iam_*
resources
#11890
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 49 Click here to see the affected service packages
Tests were added that are skipped in VCR:
View the build log |
Here's a build running the 3 skipped tests mentioned above: https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_GOOGLE_MMUPSTREAMTESTS_GOOGLE_PACKAGE_BIGTABLE/243380?hideTestsFromDependencies=false&hideProblemsFromDependencies=false&expandBuildChangesSection=true |
☝️ The 3 tests passed in TeamCity! Opening for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for adding the tests.
This PR
Release Note Template for Downstream PRs (will be copied)