Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix how conditions are handled in google_bigtable_instance_iam_* resources #11890

Conversation

SarahFrench
Copy link
Contributor

@SarahFrench SarahFrench commented Oct 2, 2024

This PR

  1. Converts existing BigTable IAM acceptance tests to use the context pattern
  2. Updates BigTable IAM code to use policy version 3
  3. Adds new acceptance tests showing conditions can be used and imported

Release Note Template for Downstream PRs (will be copied)

bigtable: fixed an error where BigTable IAM resources could be created with conditions but the condition was not stored in state

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 296 insertions(+), 57 deletions(-))
google-beta provider: Diff ( 3 files changed, 296 insertions(+), 57 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 49
Passed tests: 0
Skipped tests: 49
Affected tests: 0

Click here to see the affected service packages
  • bigtable
#### Non-exercised tests

Tests were added that are skipped in VCR:

  • TestAccBigtableInstanceIamBinding_withCondition
  • TestAccBigtableInstanceIamMember_withCondition
  • TestAccBigtableInstanceIamPolicy_withCondition
    🟢 All tests passed!

View the build log

@SarahFrench
Copy link
Contributor Author

☝️ The 3 tests passed in TeamCity! Opening for review.

@SarahFrench SarahFrench marked this pull request as ready for review October 2, 2024 16:22
@SarahFrench SarahFrench requested a review from zli82016 October 2, 2024 16:22
Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding the tests.

@SarahFrench SarahFrench merged commit 54afca9 into GoogleCloudPlatform:main Oct 2, 2024
14 checks passed
karolgorc pushed a commit to karolgorc/magic-modules that referenced this pull request Oct 4, 2024
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Oct 7, 2024
trodge pushed a commit to trodge/magic-modules that referenced this pull request Oct 10, 2024
karolgorc pushed a commit to karolgorc/magic-modules that referenced this pull request Oct 11, 2024
gontech pushed a commit to gontech/magic-modules that referenced this pull request Oct 16, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 23, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 24, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants