Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix slice init length #11919

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

cuishuang
Copy link
Contributor

@cuishuang cuishuang commented Oct 4, 2024

The intention here should be to initialize a slice with a capacity of length rather than initializing the length of this slice.

The online demo: https://go.dev/play/p/q1BcVCmvidW

Release Note Template for Downstream PRs (will be copied)

fix: fix slice init length

@github-actions github-actions bot requested a review from ScottSuarez October 4, 2024 08:10
Copy link

github-actions bot commented Oct 4, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Oct 4, 2024
@ScottSuarez
Copy link
Contributor

ooo nice catch !

@modular-magician modular-magician added service/compute-vpc and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Oct 4, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1026
Passed tests: 945
Skipped tests: 74
Affected tests: 7

Click here to see the affected service packages
  • compute

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeProjectMetadataItem_basic
  • TestAccComputeProjectMetadataItem_basicUpdate
  • TestAccComputeProjectMetadataItem_basicWithEmptyVal
  • TestAccComputeProjectMetadataItem_exists
  • TestAccComputeProjectMetadata_basic
  • TestAccComputeProjectMetadata_modify_1
  • TestAccComputeProjectMetadata_modify_2

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeProjectMetadataItem_basic[Debug log]
TestAccComputeProjectMetadataItem_basicUpdate[Debug log]
TestAccComputeProjectMetadataItem_basicWithEmptyVal[Debug log]
TestAccComputeProjectMetadataItem_exists[Debug log]
TestAccComputeProjectMetadata_basic[Debug log]
TestAccComputeProjectMetadata_modify_1[Debug log]
TestAccComputeProjectMetadata_modify_2[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@ScottSuarez ScottSuarez merged commit 94e1f8c into GoogleCloudPlatform:main Oct 4, 2024
13 of 15 checks passed
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Oct 7, 2024
trodge pushed a commit to trodge/magic-modules that referenced this pull request Oct 10, 2024
karolgorc pushed a commit to karolgorc/magic-modules that referenced this pull request Oct 11, 2024
gontech pushed a commit to gontech/magic-modules that referenced this pull request Oct 16, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 23, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 24, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants