Set unit settings to undefined on clear unit type #21399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisoelkers
requested changes
Jan 22, 2025
Co-authored-by: Dennis Oelkers <[email protected]>
dennisoelkers
approved these changes
Jan 22, 2025
…a-unit/issue-21398
maxiadlovskii
deleted the
fix/issue-when-try-to-save-widget-without-a-unit/issue-21398
branch
maxiadlovskii
added a commit
that referenced
this pull request
Jan 22, 2025
9 tasks
dennisoelkers
pushed a commit
that referenced
this pull request
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR set unit settings to undefined on clear unit type. In this case instead of empty object we send undefined to BE and that fix an issue
Motivation and Context
fix: #21398
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: