Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rethrow policy #5063

Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ouroboros-network/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,12 @@

## 0.19.0.2 -- 2025-02-03

### Breaking changes

### Non-breaking changes

* UnknownMiniProtocol error should not crash the node

## 0.19.0.1 -- 2025-01-15

### Breaking changes
Expand Down
5 changes: 1 addition & 4 deletions ouroboros-network/src/Ouroboros/Network/Diffusion/P2P.hs
Original file line number Diff line number Diff line change
Expand Up @@ -745,11 +745,8 @@ runM Interfaces
Nothing -> mempty)
<>
RethrowPolicy (\ctx err -> case (ctx, fromException err) of
-- mux unknown mini-protocol errors on the outbound
-- side are fatal, since this is misconfiguration of the
-- ouroboros-network stack.
(OutboundError, Just Mx.UnknownMiniProtocol {})
-> ShutdownNode
-> ShutdownPeer
_ -> mempty)


Expand Down
Loading