Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rethrow policy #5063

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Fix rethrow policy #5063

merged 2 commits into from
Feb 3, 2025

Conversation

crocodile-dentist
Copy link
Contributor

Description

UnknownMiniProtocol error should not crash the node.

Checklist

Quality

  • Commit sequence makes sense and have useful messages, see ref.
  • New tests are added and existing tests are updated.
  • Self-reviewed the PR.

Maintenance

  • Linked an issue or added the PR to the current sprint of ouroboros-network project.
  • Added labels.
  • Updated changelog files.
  • The documentation has been properly updated, see ref.

@crocodile-dentist crocodile-dentist requested a review from a team as a code owner February 3, 2025 17:05
coot
coot requested changes Feb 3, 2025
View reviewed changes
ouroboros-network/CHANGELOG.md Outdated Show resolved Hide resolved
@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/release/ouroboros-network-0.19 branch from 653d62e to 1705b78 Compare February 3, 2025 17:09
@crocodile-dentist
Fix rethrow policy
8c4891c 
UnknownMiniProtocol errors, even on the outbound side, should not
trigger a node shutdown.
@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/release/ouroboros-network-0.19 branch from 1705b78 to 8c4891c Compare February 3, 2025 19:06
coot
coot approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coot coot requested a review from a team as a code owner February 3, 2025 20:43
@crocodile-dentist crocodile-dentist merged commit 6065cff into release/ouroboros-network-0.19 Feb 3, 2025
12 checks passed
@crocodile-dentist crocodile-dentist deleted the mwojtowicz/release/ouroboros-network-0.19 branch February 3, 2025 21:13
@coot coot added the diffusion Issues / PRs related to diffusion layer label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coot coot coot approved these changes

Assignees

@crocodile-dentist crocodile-dentist

Labels
diffusion Issues / PRs related to diffusion layer
Projects
Ouroboros Network
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crocodile-dentist @coot