feat(manager): enable servers with valid domains #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortuna
changed the title
fortuna
commented
Nov 14, 2023
| @@ -927,8 +927,6 @@ export class AppRoot extends polymerElementWithLocalize { | |||
| const manualEntry = this.$.manualEntry as OutlineManualServerEntry; | |||
| if (clickedButtonIndex === 1) { | |||
| manualEntry.retryTapped(); | |||
| } else { | |||
There was a problem hiding this comment.
No need to dismiss the add server screen when we dismiss the dialogue!
| @@ -193,6 +193,8 @@ function main() { | |||
| // prevent window being garbage collected | |||
| let mainWindow: Electron.BrowserWindow; | |||
|
|
|||
| app.userAgentFallback = `OutlineManager/${electron.app.getVersion()} ${app.userAgentFallback}`; | |||
There was a problem hiding this comment.
This is to allow the use of ngrok without the interstitial of the free version. But I also think it's helpful to tell we are using the Outline Manager.
daniellacosse
approved these changes
Nov 15, 2023
| @@ -25,7 +25,7 @@ class ManualServer extends ShadowboxServer implements server.ManualServer { | |||
| private forgetCallback: Function | |||
| ) { | |||
| super(id); | |||
| const fingerprint = hexToString(manualServerConfig.certSha256); | |||
| const fingerprint = hexToString(manualServerConfig.certSha256 || ''); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to add servers when they have a valid domain, working on the browser.