-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(manager): enable servers with valid domains #1448
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,7 +25,7 @@ class ManualServer extends ShadowboxServer implements server.ManualServer { | |
private forgetCallback: Function | ||
) { | ||
super(id); | ||
const fingerprint = hexToString(manualServerConfig.certSha256); | ||
const fingerprint = hexToString(manualServerConfig.certSha256 || ''); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: prefer There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
this.setManagementApi(makePathApiClient(manualServerConfig.apiUrl, fingerprint)); | ||
} | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -927,8 +927,6 @@ export class AppRoot extends polymerElementWithLocalize { | |
const manualEntry = this.$.manualEntry as OutlineManualServerEntry; | ||
if (clickedButtonIndex === 1) { | ||
manualEntry.retryTapped(); | ||
} else { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No need to dismiss the add server screen when we dismiss the dialogue! |
||
manualEntry.cancelTapped(); | ||
} | ||
}); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to allow the use of ngrok without the interstitial of the free version. But I also think it's helpful to tell we are using the Outline Manager.