Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Clean Architecture & Add domain, data Module #25

Merged
merged 3 commits into from
Jun 9, 2023
Merged

Convert Clean Architecture & Add domain, data Module #25

merged 3 commits into from
Jun 9, 2023

Conversation

KanuKim97
Copy link
Owner

@KanuKim97 KanuKim97 commented Jun 6, 2023 •
edited
Loading

Convert Clean Architecture

  1. domain module
  • usecase package (apiUseCase, database RoomORM UseCase)
  • repository package
  • entity package
  1. data module
  • database package (Room ORM DAO, Tables)
  • remote package (Retrofit Interface, response model)
  • repositoryImpl package (domain Repository Implement)
  • util package
    • apiMapper -> toDomain Entity,
    • databaseMapper -> toDomain Entity, toData Table
  1. app module
  • mod app module
  • delete old codes
  1. mod build.gradle
  • update build.gradle version 8.0.2
  • update build.gradle(:Module) Java Version to 17
  • add more dependencies on data, domain module

Issues

#26 [Bug Report] E/RecyclerView: No adapter attached; skipping layout
#27 [Bug Report] InsertTickerUseCase is doesn't working

@KanuKim97
Add domain, data module
dee4ed8 
Add domain, data module
1. domain module
 - add entity package
 - add repository package
 - add usecase package
2. add data module
 - add database package
 - add remote package
 - add util(Mapper) package
3. mod app module
4. fix build.gradle(app, data, domain)
5. issue : No adapter attached
@KanuKim97 KanuKim97 added bug Something isn't working enhancement New feature or request labels Jun 6, 2023
@KanuKim97 KanuKim97 self-assigned this Jun 6, 2023
@KanuKim97 KanuKim97 added this to the Clean Architecture 전환 milestone Jun 6, 2023
@KanuKim97 KanuKim97 linked an issue Jun 6, 2023 that may be closed by this pull request
[Bug Report] E/RecyclerView: No adapter attached; skipping layout #26
Closed
@KanuKim97 KanuKim97 added Clean architecture Refactoring clean architecture Refactoring Refactoring code labels Jun 6, 2023
@KanuKim97
Fix Issue #26
0ea1a44 
Fix Issue #26
@KanuKim97 KanuKim97 linked an issue Jun 7, 2023 that may be closed by this pull request
[Bug Report] InsertTickerUseCase가 작동하지 않음 #27
Closed
@KanuKim97 KanuKim97 changed the title Add domain, data module Change Clean Architecture & Add domain, data Module Jun 7, 2023
@KanuKim97 KanuKim97 changed the title Change Clean Architecture & Add domain, data Module Convert Clean Architecture & Add domain, data Module Jun 7, 2023
@KanuKim97
1. fix Gradle Version
c1025ca 
 - JAVA VERSION 1.8 -> VERSION 17
2. fix #27 Issue
3. fix domain, data AndroidManifest.xml
 - delete <application> tag
4. add annotation on DispatcherModule.kt, DispatcherQualifier.kt, AlertDialogModule.kt
5. rename TickerRemoteModule.kt -> BithumbApiModule.kt
6. delete MainDispatcher Each Views
@KanuKim97 KanuKim97 merged commit 2a11f43 into develop Jun 9, 2023
@KanuKim97 KanuKim97 deleted the refactor/clean_architecture branch June 9, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KanuKim97 KanuKim97

Labels
bug Something isn't working Clean architecture Refactoring clean architecture enhancement New feature or request Refactoring Refactoring code
Projects
None yet
Milestone
Clean Architecture 전환
1 participant
@KanuKim97