Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Clean Architecture & Add domain, data Module #25

Merged
merged 3 commits into from
Jun 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,13 @@ android {
}

compileOptions {
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
sourceCompatibility JavaVersion.VERSION_17
targetCompatibility JavaVersion.VERSION_17
}

kotlinOptions {
freeCompilerArgs += [ "-Xjvm-default=all"]
jvmTarget = '1.8'
jvmTarget = '17'
}

buildFeatures { viewBinding = true }
Expand All @@ -46,16 +46,17 @@ kapt { correctErrorTypes = true }

dependencies {
//Android X, constraintLayout, navigation
implementation 'androidx.core:core-ktx:1.10.0'
implementation 'androidx.core:core-ktx:1.10.1'
implementation 'androidx.appcompat:appcompat:1.6.1'

implementation 'com.google.android.material:material:1.8.0'
implementation 'androidx.constraintlayout:constraintlayout:2.1.4'
implementation "androidx.navigation:navigation-fragment-ktx:2.5.3"
implementation "androidx.navigation:navigation-ui-ktx:2.5.3"
implementation "androidx.navigation:navigation-fragment-ktx:2.6.0"
implementation "androidx.navigation:navigation-ui-ktx:2.6.0"

// Android material
implementation 'com.google.android.material:material:1.8.0'
implementation 'com.google.android.material:material:1.9.0'
implementation project(path: ':data')
implementation project(path: ':domain')

// Android Test Tool
testImplementation 'junit:junit:4.13.2'
Expand All @@ -73,8 +74,7 @@ dependencies {
//Android Jetpack ViewModel
implementation "androidx.lifecycle:lifecycle-viewmodel-ktx:2.6.1"

//Android Jetpack LiveData`

//Android Jetpack LiveData
implementation "androidx.lifecycle:lifecycle-livedata-ktx:2.6.1"

// Kotlin Coroutine
Expand Down
10 changes: 5 additions & 5 deletions app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<uses-permission android:name="android.permission.INTERNET" />

<application
android:name=".AndroidApp"
android:name=".presenter.AndroidApp"
android:allowBackup="true"
android:icon="@mipmap/ic_launcher"
android:label="@string/app_name"
Expand All @@ -12,11 +12,11 @@
android:theme="@style/Theme.Koin_Apps">

<activity
android:name=".SelectKoinActivity"
android:name=".presenter.SelectKoinActivity"
android:exported="false" />

<activity
android:name=".LogoActivity"
android:name=".presenter.LogoActivity"
android:exported="true">
<intent-filter>
<action android:name="android.intent.action.MAIN" />
Expand All @@ -25,11 +25,11 @@
</activity>

<activity
android:name=".LiveTimeActivity"
android:name=".presenter.LiveTimeActivity"
android:exported="false" />

<activity
android:name=".MainActivity"
android:name=".presenter.MainActivity"
android:exported="false" />

<meta-data
Expand Down
46 changes: 0 additions & 46 deletions app/src/main/java/com/example/koin_apps/LogoActivity.kt

This file was deleted.

62 changes: 0 additions & 62 deletions app/src/main/java/com/example/koin_apps/MainActivity.kt

This file was deleted.

86 changes: 0 additions & 86 deletions app/src/main/java/com/example/koin_apps/OrderBookFragment.kt

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ package com.example.koin_apps.common
object Constants {
const val BITHUMB_PUBLIC_API_URL: String = "https://api.bithumb.com/public/"
const val DELAY_TIME_MILLIS: Long = 1000L
const val RETRY_MAX_ATTEMPT: Int = 3
const val LOG_TAG: String = "로그"
const val LOG_ERROR_TAG: String = "에러"
const val RETRY_MAX_ATTEMPT = 3
}

This file was deleted.

This file was deleted.

Loading