Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed vulkan sub-tests overlapping with semaphore negative tests #2250

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shajder
Copy link
Contributor

@shajder shajder commented Jan 27, 2025

Fixes #2153 according to issue description.

@nikhiljnv
Copy link
Contributor

nikhiljnv commented Jan 28, 2025

@shajder Can you call out what specific tests are being removed as part of this PR which exist in cl_khr_semaphore ?

@shajder
Copy link
Contributor Author

shajder commented Jan 30, 2025

@shajder Can you call out what specific tests are being removed as part of this PR which exist in cl_khr_semaphore ?

Of course. Removed four tests (wait/signal in one link):

-passing NULL properties to clCreateSemaphoreWithPropertiesKHR here
-passing invalid semaphore for clEnqueueSignalSemaphoresKHR/clEnqueueWaitSemaphoresKHR here
-passing NULL semaphore for clReleaseSemaphoreKHR/clRetainSemaphoreKHR here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_vulkan overlaps negative testing from cl_khr_semaphore
2 participants