Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed vulkan sub-tests overlapping with semaphore negative tests #2250

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Removed vulkan sub-tests overlapping with semaphore negative tests #2250

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e52c30e
Removed vulkan sub-tests overlapping with semaphore negative tests
shajder Jan 27, 2025
2a08fcc
Merge branch 'main' into vulkan_remove_semaphore_overlap
shajder Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 0 additions & 30 deletions test_conformance/vulkan/test_vulkan_api_consistency.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,29 +476,6 @@ struct ConsistencyExternalSemaphoreTest : public VulkanTestBase
sema_props1.push_back(0);
sema_props2.push_back(0);

// Pass NULL properties
clCreateSemaphoreWithPropertiesKHRptr(context, NULL, &errNum);
test_failure_error(
errNum, CL_INVALID_VALUE,
"Semaphore creation must fail with CL_INVALID_VALUE "
" when properties are passed as NULL");

// Pass invalid semaphore object to wait
errNum = clEnqueueWaitSemaphoresKHRptr(queue, 1, NULL, NULL, 0,
NULL, NULL);
test_failure_error(errNum, CL_INVALID_SEMAPHORE_KHR,
"clEnqueueWaitSemaphoresKHR fails with "
"CL_INVALID_SEMAPHORE_KHR "
"when invalid semaphore object is passed");

// Pass invalid semaphore object to signal
errNum = clEnqueueSignalSemaphoresKHRptr(queue, 1, NULL, NULL, 0,
NULL, NULL);
test_failure_error(errNum, CL_INVALID_SEMAPHORE_KHR,
"clEnqueueSignalSemaphoresKHR fails with "
"CL_INVALID_SEMAPHORE_KHR"
"when invalid semaphore object is passed");

// Create two semaphore objects
clVk2Clsemaphore = clCreateSemaphoreWithPropertiesKHRptr(
context, sema_props1.data(), &errNum);
Expand All @@ -512,13 +489,6 @@ struct ConsistencyExternalSemaphoreTest : public VulkanTestBase
errNum,
"Unable to create semaphore with valid semaphore properties");

// Pass invalid object to release call
errNum = clReleaseSemaphoreKHRptr(NULL);
test_failure_error(errNum, CL_INVALID_SEMAPHORE_KHR,
"clReleaseSemaphoreKHRptr fails with "
"CL_INVALID_SEMAPHORE_KHR when NULL semaphore "
"object is passed");

// Release both semaphore objects
errNum = clReleaseSemaphoreKHRptr(clVk2Clsemaphore);
test_error(errNum, "clReleaseSemaphoreKHRptr failed");
Expand Down
Loading