Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update checks for info::device::execution_capabilities in device_info test #1020

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

KseniyaTikhomirova
Copy link
Contributor

@KseniyaTikhomirova KseniyaTikhomirova commented Jan 17, 2025

Test update corresponding to KhronosGroup/SYCL-Docs#625
Fixes #945

Signed-off-by: Tikhomirova, Kseniya <[email protected]>
@KseniyaTikhomirova KseniyaTikhomirova requested a review from a team as a code owner January 17, 2025 16:08
@CLAassistant
Copy link

CLAassistant commented Jan 17, 2025

CLA assistant check
All committers have signed the CLA.

@bader
Copy link
Contributor

bader commented Jan 17, 2025

@KseniyaTikhomirova, please, sign CLA -> #1020 (comment).

@KseniyaTikhomirova
Copy link
Contributor Author

@KseniyaTikhomirova, please, sign CLA -> #1020 (comment).

done!

Copy link
Member

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bader bader merged commit 05c4280 into KhronosGroup:main Jan 23, 2025
8 checks passed
sarnex pushed a commit to intel/llvm that referenced this pull request Jan 23, 2025
Aligns behavior with
https://github.com/KhronosGroup/SYCL-Docs/pull/625/files
Test update to pair it with:
KhronosGroup/SYCL-CTS#1020

Done in RT for simplicity. 
Since execution_capability is marked as deprecated I would suggest to
make update in UR & UR adapters after it is completely removed.

---------

Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Spec change] Clarify and deprecate "execution_capabilities"
5 participants