Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add AC/DC converter series: Recom RAC20-xxSK #2692

Merged
merged 5 commits into from
Sep 24, 2020
Merged

Add AC/DC converter series: Recom RAC20-xxSK #2692

merged 5 commits into from
Sep 24, 2020

Conversation

Werni2A
Copy link
Contributor

@Werni2A Werni2A commented May 2, 2020

Adds a few AC/DC converters.

https://recom-power.com/pdf/Powerline_AC-DC/RAC20-K.pdf
Pin table

Footprint PR

I copied the symbol from RAC01-xxSGB

image


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@CLAassistant
Copy link

CLAassistant commented May 2, 2020

CLA assistant check
All committers have signed the CLA.

@myfreescalewebpage myfreescalewebpage added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer labels May 4, 2020
@myfreescalewebpage myfreescalewebpage self-assigned this Aug 24, 2020
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Aug 24, 2020
@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Aug 24, 2020

Hi @Werni2A , thanks for contributing,

A few comments I have during my review:

  • "RAC20-xxSK" should not exist. Instead you should use one of the symbol as the main symbol (5V version for example) and then make the other as alias.
  • Pin 3 is missing, should be called "NC", invisible, Not connected and placed on the border outline of the symbol

Cheers,
Joel

@Werni2A
Copy link
Contributor Author

Werni2A commented Aug 25, 2020

Hi Joel, thank you or the review.

I removed the generic part "RAC20-xxSK" and also changed the footprint filter to be more precise. Maybe you can take a look at that again.

Concerning your second point. The missing pin 3 is just I would say a naming convention for this kind of parts. The pin is physically missing therefore NC would be in my opinion inappropriate because there is no pin to connect to. Please take a look at the footprint. What do you think about that?

@myfreescalewebpage
Copy link
Collaborator

Thanks. Yes sorry for pin 3 , thanks to point that. In this case we do not add it.
For the fp filter I prefer Converter*ACDC*RECOM*RAC20*SK*THT*
Joel

@myfreescalewebpage myfreescalewebpage added the Pending footprint Pending footprint acceptance before merging label Aug 25, 2020
@Werni2A
Copy link
Contributor Author

Werni2A commented Aug 25, 2020

@myfreescalewebpage I reset the footprint filter to the original one :)

@myfreescalewebpage
Copy link
Collaborator

Thanks!
Just need to wait the footprint now.
Joel

@myfreescalewebpage
Copy link
Collaborator

Closing/opening to refresh the Travis test.

@myfreescalewebpage
Copy link
Collaborator

Closing/opening to refresh the Travis test.

@myfreescalewebpage
Copy link
Collaborator

@Werni2A there is a case issue here on the footprint and footprint filter. "RECOM"->"Recom". Then ready to be merged.
Joel

@Werni2A
Copy link
Contributor Author

Werni2A commented Sep 24, 2020

@myfreescalewebpage I adjusted both fields. The CI should now succeed. Thanks for you effort.

@myfreescalewebpage
Copy link
Collaborator

Thanks for the fix, merging now

@myfreescalewebpage myfreescalewebpage merged commit 51450b5 into KiCad:master Sep 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants