chore(env) update router default #911
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainest
force-pushed
the
chore/router-default
branch
2 times, most recently
from
68698bc to
3a9ca76
Compare
pmalek
reviewed
Oct 23, 2023
rainest
force-pushed
the
chore/router-default
branch
from
ad18df5 to
c2289d7
Compare
|
Given Kong/kubernetes-ingress-controller#5018 (comment) we're presumably doing a bit more around this other than just flipping it. Nothing of particular interest here anyway, so just closing this to clean up stale PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Changes the router default to
expressions.Notes this as a breaking change in unreleased release notes.
Which issue this PR fixes
Part of Kong/kubernetes-ingress-controller#4719
Special notes for your reviewer:
Ditto open questions in Kong/kubernetes-ingress-controller#4934
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
mainbranch.