Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(env) update router default #911

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions charts/ingress/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
# Changelog

## Unreleased

### Breaking changes

* The `env.router_flavor` default is now `expressions`. This requires Kong
3.4.1 or higher and controller 3.0.0 or higher. Releases using older image
versions should change this value to `traditional`
[#911](https://github.com/Kong/charts/pull/911)

## 0.7.0

- Bumped dependency `kong/kong` minimum to `2.28.1`. Review the [kong chart
Expand Down
5 changes: 5 additions & 0 deletions charts/ingress/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ controller:

ingressController:
enabled: true
image:
repository: kong/nightly-ingress-controller
tag: "nightly"
effectiveSemver: "3.0.0"

gatewayDiscovery:
enabled: true
Expand All @@ -36,3 +40,4 @@ gateway:
env:
role: traditional
database: "off"
router_flavor: "expressions"
2 changes: 0 additions & 2 deletions charts/kong/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
# Changelog

## Unreleased

### Improvements

* Prevent installing PodDisruptionBudget for `replicaCount: 1` or `autoscaling.minReplicas: 1`.
Expand Down
6 changes: 1 addition & 5 deletions charts/kong/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,7 @@ deployment:
# is set below. In general, you should not set values here if they are set elsewhere.
env:
database: "off"
# the chart uses the traditional router (for Kong 3.x+) because the ingress
# controller generates traditional routes. if you do not use the controller,
# you may set this to "traditional_compatible" or "expressions" to use the new
# DSL-based router
router_flavor: "traditional"
router_flavor: "traditional_compatible"
nginx_worker_processes: "2"
proxy_access_log: /dev/stdout
admin_access_log: /dev/stdout
Expand Down
Loading