-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: WebAssembly filter chains #362
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #362 +/- ##
==========================================
+ Coverage 59.32% 59.34% +0.01%
==========================================
Files 69 71 +2
Lines 4219 4378 +159
==========================================
+ Hits 2503 2598 +95
- Misses 1134 1170 +36
- Partials 582 610 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ba69f3f
to
982daa2
Compare
Regarding the failing test: we probably need |
982daa2
to
aff3a73
Compare
aff3a73
to
087c590
Compare
|
CI problems... The nightly tests were using an old tag (
|
74d509d
to
9bc2d81
Compare
a846c8c
to
70da1db
Compare
Lint fixes are in #421 |
d0e1d08
to
2ee7cad
Compare
I had to fix a host of testing problems in order to get CI working against Kong nightly/master, so there are a bunch of additional commits in this PR. I can move them to another PR if desired. |
@hishamhm who is a good person to tag for review on this? |
Fixes for minor issues caught when adapting these for the FilterChains service tests.
A new `realm` field was recently added to the basic-auth plugin: Kong/kong#11795 To address this I added version awareness to the test cases.
The dev portal is deprecated and now requires a special secret to enable, so it is no longer feasible to test this in nightly (>=3.7). Kong/kong-ee#6812
2ee7cad
to
d672dfd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The consumer groups stuff should have probably gone in separately but otherwise the new entity looks fine.
#362 (comment) is being addressed in #432 |
This PR introduces the FilterChains entity, a new entity released in Kong Gateway 3.4 (OSS and Enterprise) to manage WebAssembly filters ("filters" are the WebAssembly analog to Lua plugins — we call them filters because it's the already-established terminology used by the proxy-wasm API we implemented, which is also implemented by other WebAssembly-enabled gateways such as Envoy).
KAG-4005
KOKO-1274