Add thin optical elements in lasy
#199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
RemiLehe
force-pushed
the
optical_elements
branch
2 times, most recently
from
e9d758b to
682b058
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
RemiLehe
force-pushed
the
optical_elements
branch
from
682b058 to
3cf7182
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
This is great. I know it's early work, but would it make sense to be able to define something like an |
RemiLehe
force-pushed
the
optical_elements
branch
from
6c268b9 to
343e05e
Compare
RemiLehe
commented
Jul 15, 2024
| """ | ||
| # Transform the field from temporal to frequency domain | ||
| time_axis_indx = -1 | ||
| field_fft = np.fft.ifft(self.grid.field, axis=time_axis_indx, norm="backward") |
There was a problem hiding this comment.
The implementation is not efficient currently, as it performs FFTs forward and backward.
This will be fixed in #256, by keeping the Fourier-space fields in memory and having a flag that keeps track of this.
RemiLehe
changed the title
lasylasy
RemiLehe
force-pushed
the
optical_elements
branch
from
1d248d3 to
12d6ee8
Compare
for more information, see https://pre-commit.ci
RemiLehe
commented
Jul 15, 2024
| @@ -160,6 +160,46 @@ def normalize(self, value, kind="energy"): | |||
| else: | |||
| raise ValueError(f'kind "{kind}" not recognized') | |||
|
|
|||
| def apply_optics(self, optical_element): | |||
Merged
RemiLehe
changed the title
lasylasy
MaxThevenet
reviewed
Jul 16, 2024
lasy/laser.py
Outdated
|
|
||
| # Apply optical element | ||
| if self.dim == "rt": | ||
| r, w = np.meshgrid(self.grid.axes[0], omega, indexing="ij") |
There was a problem hiding this comment.
Minor comment: might be a bit dangerous to mix w and omega.
lasy/laser.py
Outdated
|
|
||
| # Apply optical element | ||
| if self.dim == "rt": | ||
| r, w = np.meshgrid(self.grid.axes[0], omega, indexing="ij") |
There was a problem hiding this comment.
(same as comment in optical_element.py: should the meshgrid be done in the optical element? Could just be an option)
Co-authored-by: Maxence Thévenet <[email protected]>
Co-authored-by: Maxence Thévenet <[email protected]>
RemiLehe
commented
Jul 16, 2024
| # along theta (FT_theta). Because the multiplier is assumed to be | ||
| # cylindrically symmetric (i.e. theta-independent): | ||
| # FT_theta[ multiplier * field ] = multiplier * FT_theta[ field ] | ||
| # Thus, we can simply multiply each azimuthal mode by the multiplier. |
There was a problem hiding this comment.
I added more explanations here.
MaxThevenet
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is one suggested way to add thin optical elements in
lasy, through which the laser profiles can be propagated. This is heavily inspired by examples inaxiprop.Thin elements are represented by their complex multiplying factor
T(x, y, omega)and are therefore applied after performing one Fourier transform on the laser profile, along the time axis. This PR only implements one optical element (ParabolicMirror), but more will be added next.For this reason, I chose to have the user pass the optical element to theIn the latest version, the API has been changed.propagatefunction (since this function starts by performing a Fourier transform along the time axis)