Amg comm cali v2 #318
Draft
Amg comm cali v2 #318
+306
−112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
experiment
pearce8
reviewed
Jul 23, 2024
There was a problem hiding this comment.
This file should not be in this PR.
There was a problem hiding this comment.
@gracenansamba Please test this on Dane using the Dane config I just added. We should stop using the Magma config on other systems. Please also test the develop on Dane.
rfhaque
reviewed
Aug 9, 2024
| @@ -34,7 +34,8 @@ ramble: | |||
| software: | |||
| packages: | |||
| osu-micro-benchmarks: | |||
| pkg_spec: osu-micro-benchmarks | |||
| pkg_spec: osu-micro-benchmarks@comm_cali +mpi+openmp{modifier_spack_variant} | |||
| # pkg_spec: osu-micro-benchmarks | |||
There was a problem hiding this comment.
@gracenansamba @pearce8 osu-micro-benchmarks does not support the mpi and openmp variants (mpi is always enabled). We also need to add the comm_cali branch to the osu-micro-benchmarks package.py. It may be better to separate the amg2023 and OSU changes into two PRs. amg2023 comm_cali changes work on ruby and can be taken to main as its own PR.
Draft
rfhaque
reviewed
Aug 15, 2024
| @@ -31,7 +31,7 @@ class Amg2023(CMakePackage, CudaPackage, ROCmPackage): | |||
| depends_on("caliper", when="+caliper") | |||
| depends_on("adiak", when="+caliper") | |||
| depends_on("hypre+caliper", when="+caliper") | |||
| depends_on("[email protected]:") | |||
| depends_on("hypre@3.1_comm_cali") #depends_on("hypre@2.31.0:") | |||
There was a problem hiding this comment.
Suggested change
| depends_on("hypre@3.1_comm_cali") #depends_on("hypre@2.31.0:") | |
| depends_on("[email protected]:", when="~caliper") | |
| depends_on("[email protected]_comm_cali", when="+caliper") |
gracenansamba
force-pushed
the
amg_comm_cali_v2
branch
from
2a2ff50 to
480cedf
Compare
gracenansamba
force-pushed
the
amg_comm_cali_v2
branch
from
480cedf to
1fde852
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On this branch, I have added the new version on hypre and build on both
LLNL-Magma-Penguin-icelake-OmniPath and LLNL-Ruby-icelake-OmniPath but it gives the error below
Error: mvapich2-2.3.7-gcc1211-ba7pgawdzevxpglrdk24r535qxzwjig6 cannot be installed locally: is external
[+] /usr/tce/packages/mvapich2/mvapich2-2.3.7-gcc-12.1.1 (external mvapich2-2.3.7-gcc1211-ba7pgawdzevxpglrdk24r535qxzwjig6)
[+] /usr/tce/backend/installations/linux-rhel8-x86_64/intel-19.0.4/intel-oneapi-mkl-2022.1.0-sksz67twjxftvwchnagedk36gf7plkrp (external intel-oneapi-mkl-2022.1.0-7llgckpv3lwue4s5wvqv5v5kl4ffwttk)
[+] /usr/tce/packages/cmake/cmake-3.23.1 (external cmake-3.23.1-6iyz3a45sv25ts5ztlhpcegyj6lm57jr)
[+] /usr (external glibc-2.28-beut3q26btehwxb2iorw4r5ujpbfgpo3)
[+] /usr (external gmake-4.2.1-k6pc4zc3jem34sxxp32fal6o5ydskw2b)
==> Error: Command exited with status 1:
'/g/g91/nansamba1/intern/benchparkRunsJuly22_amg2023/spack/bin/spack' 'install' '--add' '--keep-stage'
==> Error: Error running spack command: /g/g91/nansamba1/intern/benchparkRunsJuly22_amg2023/spack/bin/spack install --add --keep-stage
==> Error: For more details, see the log file: /g/g91/nansamba1/intern/benchparkRunsJuly22_laghos/amg2023/openmp/LLNL-Ruby-icelake-OmniPath/workspace/logs/setup.2024-07-22_16.35.57/amg2023.problem1.amg2023_omp_problem1_1_4_2_2_2_55_55_55.out