Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Review Squad 3 Laura V Bailon M #44

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

9JazzCodeLBM
Copy link

¡Hola Adri !

Envío mi primer PULL REQUEST, avances de html y css, sigo trabajando con JS.
Use las etiquetas de HTML5 para estructurar mis archivos.

De antemano, gracias por la revisión.

Atte. Laura V. Bailón M.

const decipher = {
// ...
};

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Esta parte que hace? por qué la pusimos?

Copy link

@AdrianaHY AdrianaHY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muy buen avance! solo hay que poner atención en los objetos de cipher, no son necesarios ambos, tienes tu objeto cipher y dentro lleva las dospropiedades: encode y decode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants