-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Review Squad 3 Laura V Bailon M #44
Open
9JazzCodeLBM
wants to merge
20
commits into
Laboratoria:master
Choose a base branch
from
9JazzCodeLBM:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
66c3813
todo listo
9JazzCodeLBM 34b7ddb
Mi primer Code Review
9JazzCodeLBM 70959a6
Add files via upload
9JazzCodeLBM 11f5066
Delete Captura de pantalla de 2020-02-14 14-50-11.png
9JazzCodeLBM ad1f9fc
Delete Captura de pantalla de 2020-02-14 14-52-03.png
9JazzCodeLBM 23b7e83
Delete Captura de pantalla de 2020-02-14 14-50-15.png
9JazzCodeLBM acf1df7
Delete Captura de pantalla de 2020-02-14 14-50-18.png
9JazzCodeLBM 415b5f3
Delete Captura de pantalla de 2020-02-14 14-50-21.png
9JazzCodeLBM d6ade6e
Delete Captura de pantalla de 2020-02-14 14-51-35.png
9JazzCodeLBM bfddbb7
Add files via upload
9JazzCodeLBM c2ba952
Update README.md
9JazzCodeLBM ad9dfd3
Update README.md
9JazzCodeLBM 8680f92
Update README.md
9JazzCodeLBM d56219e
Update README.md
9JazzCodeLBM 7f93488
Update README.md
9JazzCodeLBM c77d09f
Update README.md
9JazzCodeLBM d82de2b
Update README.md
9JazzCodeLBM b9b6e2b
Add files via upload
9JazzCodeLBM cba9341
Update README.md
9JazzCodeLBM 6bd03ac
Update README.md
9JazzCodeLBM File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| <!DOCTYPE html> | ||
| <html> | ||
| <head> | ||
| <meta charset="utf-8"> | ||
| <title>CIFRAR</title> | ||
| <link rel="stylesheet" href="style2.css"/> | ||
| </head> | ||
| <body class="section3"> | ||
| <main> | ||
| <header> | ||
| </header> | ||
| <nav> | ||
| <ul> | ||
| <a href="index.html">Inicio</a> | ||
| <a href="decipher.htm">Descifrar</a> | ||
| </ul> | ||
| </nav> | ||
| <section> | ||
| <article class=""> | ||
| <p>Hola nombre</p><br> | ||
| <form action=""> | ||
| Elige un número ¡Recuerda también enviar este número a tu contacto!:<br> | ||
| <input type="text" id=""><br> | ||
| Escribe tu mensaje a cifrar:<br> | ||
| <input type="text" id=""><br> | ||
| <input type="button" value="CIFRAR" onclick="alert()"> | ||
| </form><br> | ||
| </article> | ||
| </section> | ||
| <aside class=""> | ||
| <button onclick="window.location.href = 'decipher.htm';">DESCIFRAR</button> | ||
| <button onclick="window.location.href = 'index.html';">INICIO</button> | ||
| </aside> | ||
| <footer> REDES SOCIALES </footer> | ||
| </main> | ||
| </body> | ||
| </html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,3 +3,9 @@ const cipher = { | |
| }; | ||
|
|
||
| export default cipher; | ||
|
|
||
| const decipher = { | ||
| // ... | ||
| }; | ||
|
|
||
| export default decipher; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
|
|
||
| <!DOCTYPE html> | ||
| <html> | ||
| <head> | ||
| <meta charset="utf-8"> | ||
| <title>DESCIFRAR</title> | ||
| <link rel="stylesheet" href="style3.css"/> | ||
| </head> | ||
| <body class="section4"> | ||
| <main> | ||
| <header> | ||
| </header> | ||
| <nav> | ||
| <ul> | ||
| <a href="index.html">Inicio</a> | ||
| <a href="cipher.htm">Cifrar</a> | ||
| </ul> | ||
| <section> | ||
| <article class=""> | ||
| <p>Hola nombre</p><br> | ||
| <form action=""> | ||
| Introduce el número que tu contacto envío:<br> | ||
| <input type="text" id=""><br> | ||
| Escribe tu mensaje cifrado:<br> | ||
| <input type="text" id=""><br> | ||
| <input type="button" value="DESCIFRAR" onclick="alert()"> | ||
| </form><br> | ||
| </article> | ||
| </section> | ||
| <aside class=""> | ||
| <button onclick="window.location.href = 'cipher.htm';">CIFRAR</button> | ||
| <button onclick="window.location.href = 'index.html';">INICIO</button> | ||
| </aside> | ||
| <footer> REDES SOCIALES </footer> | ||
| </main> | ||
| </body> | ||
| </html> |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,7 @@ | ||
| import cipher from './cipher.js'; | ||
|
|
||
| console.log(cipher); | ||
|
|
||
| import decipher from './cipher.js'; | ||
|
|
||
| console.log(decipher); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| <!DOCTYPE html> | ||
| <html> | ||
| <head> | ||
| <meta charset="utf-8"> | ||
| <title>BIENVENIDO</title> | ||
| <link rel="stylesheet" href="style1.css" /> | ||
| </head> | ||
| <body class="section2"> | ||
| <main> | ||
| <header> | ||
| </header> | ||
| <nav> | ||
| <ul> | ||
| <a href="index.html">Inicio</a> | ||
| </ul> | ||
| </nav> | ||
| <section> | ||
| <article class=""> | ||
| <h1>BIENVENIDO</h1><br> | ||
| <p>¿Qué quieres hacer?</p> | ||
| </article><br> | ||
| <article class="enlacepag"> | ||
| <button onclick="window.location.href = 'cipher.htm';">CIFRAR</button> | ||
| <button onclick="window.location.href = 'decipher.htm';">DESCIFRAR</button> | ||
| </article> | ||
| </section> | ||
| <footer> REDES SOCIALES </footer> | ||
| </main> | ||
| </body> | ||
| </html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| body{ | ||
| background-color: #66CCFF; | ||
| } | ||
| body.section1{ | ||
| background-image: url("./images/porta1.jpg"); | ||
| } | ||
|
|
||
| article{ | ||
| position:static; | ||
| text-align:center; | ||
| } | ||
|
|
||
| footer{ | ||
| background-color: #CEE3F6; | ||
| width: 1200px; | ||
| height: 10px; | ||
| margin: 0px; | ||
| padding: 30px; | ||
| bottom: 0px; | ||
| position: fixed; | ||
| text-align: center; | ||
| } | ||
|
|
||
| h1{ | ||
| color:#FF4500; | ||
| font-size:45px; | ||
| text-align: center; | ||
| } | ||
|
|
||
| p{ | ||
| color:#FFFFFF; | ||
| font-size:30px; | ||
| text-align: center; | ||
| } | ||
|
|
||
| input{ | ||
| width: 400px; | ||
| box-sizing: border-box; | ||
| border: 1px solid #0B0B3B; | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| body{ | ||
| background-color: #66CCFF; | ||
| } | ||
|
|
||
| body.section2{ | ||
| background-image: url("./images/porta2.jpg"); | ||
| } | ||
|
|
||
| header{ | ||
| opacity: .5; | ||
| background-color: #0B0B3B; | ||
| width: 1200px; | ||
| height: 20px; | ||
| margin: 0px; | ||
| padding: 40px; | ||
| top: 0px; | ||
| align: right; | ||
| position:static; | ||
| } | ||
|
|
||
| article{ | ||
| position:static; | ||
| text-align:center; | ||
| } | ||
|
|
||
| aside{ | ||
| position:static; | ||
| text-align:right; | ||
| } | ||
|
|
||
| footer{ | ||
| opacity: .3; | ||
| background-color: #CEE3F6; | ||
| width: 1200px; | ||
| height: 11px; | ||
| margin: 0px; | ||
| padding: 30px; | ||
| bottom: 0px; | ||
| position: fixed; | ||
| text-align: center; | ||
| } | ||
|
|
||
| h1{ | ||
| font-size:45px; | ||
| text-align: center; | ||
| } | ||
|
|
||
| p{ | ||
| font-size:30px; | ||
| text-align: center; | ||
| } | ||
|
|
||
| a{ | ||
| color:#000033; | ||
| } | ||
| a:hover{ | ||
| color:#00CCFF; | ||
| } | ||
|
|
||
| input{ | ||
| width: 400px; | ||
| box-sizing: border-box; | ||
| border: 1px solid #0B0B3B; | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| body{ | ||
| background-color: #66CCFF; | ||
| } | ||
|
|
||
| body.section3{ | ||
| background-image: url("./images/porta3.jpg"); | ||
| } | ||
|
|
||
| header{ | ||
| opacity: .5; | ||
| background-color: #0B0B3B; | ||
| width: 1200px; | ||
| height: 20px; | ||
| margin: 0px; | ||
| padding: 40px; | ||
| top: 0px; | ||
| position:static; | ||
| } | ||
|
|
||
| article{ | ||
| position:static; | ||
| text-align:center; | ||
| } | ||
|
|
||
| aside{ | ||
| position:static; | ||
| text-align:right; | ||
| } | ||
|
|
||
| footer{ | ||
| opacity: .3; | ||
| background-color: #CEE3F6; | ||
| width: 1200px; | ||
| height: 11px; | ||
| margin: 0px; | ||
| padding: 30px; | ||
| bottom: 0px; | ||
| position: fixed; | ||
| text-align: center; | ||
| } | ||
|
|
||
| h1{ | ||
| font-size:45px; | ||
| text-align: center; | ||
| } | ||
|
|
||
| p{ | ||
| font-size:30px; | ||
| text-align: center; | ||
| } | ||
|
|
||
| a{ | ||
| color:#000033; | ||
| } | ||
| a:hover{ | ||
| color:#00CCFF; | ||
| } | ||
|
|
||
| input{ | ||
| width: 400px; | ||
| box-sizing: border-box; | ||
| border: 1px solid #0B0B3B; | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| body{ | ||
| background-color: #66CCFF; | ||
| } | ||
|
|
||
| body.section4{ | ||
| background-image: url("./images/porta4.jpg"); | ||
| } | ||
|
|
||
| header{ | ||
| opacity: .5; | ||
| background-color: #0B0B3B; | ||
| width: 1200px; | ||
| height: 20px; | ||
| margin: 0px; | ||
| padding: 40px; | ||
| top: 0px; | ||
| position:static; | ||
| } | ||
|
|
||
| article{ | ||
| position:static; | ||
| text-align:center; | ||
| } | ||
|
|
||
| aside{ | ||
| position:static; | ||
| text-align:right; | ||
| } | ||
|
|
||
| footer{ | ||
| opacity: .3; | ||
| background-color: #CEE3F6; | ||
| width: 1200px; | ||
| height: 11px; | ||
| margin: 0px; | ||
| padding: 30px; | ||
| bottom: 0px; | ||
| position: fixed; | ||
| text-align: center; | ||
| } | ||
|
|
||
| h1{ | ||
| font-size:45px; | ||
| text-align: center; | ||
| } | ||
|
|
||
| p{ | ||
| font-size:30px; | ||
| text-align: center; | ||
| } | ||
|
|
||
| a{ | ||
| color:#000033; | ||
| } | ||
| a:hover{ | ||
| color:#00CCFF; | ||
| } | ||
|
|
||
| input{ | ||
| width: 400px; | ||
| box-sizing: border-box; | ||
| border: 1px solid #0B0B3B; | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Esta parte que hace? por qué la pusimos?