Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating and simplifying templates #1668

Merged
merged 7 commits into from
Dec 23, 2023
Merged

Updating and simplifying templates #1668

merged 7 commits into from
Dec 23, 2023

Conversation

x9136
Copy link
Collaborator

@x9136 x9136 commented Dec 14, 2023

Description

I suggest some changes to the templates to remove unnecessary information and clarify what is needed from the contributor.

Type of change

❌ Bug fix (non-breaking change which fixes an issue)
✅ General change (non-breaking change that doesn't fit the above categories, such as copyediting)

Changelog

  • Removed [DISCUSSION] from the issue template because it was duplicating the label.
  • Shortened the subheadings in the icon addition template because they were duplicating the header.
  • Removed the note about the icon being added from the request form, because that wasn't used and you can see in the current requests table what requests are fulfilled.
  • Removed the indentation in the icon lists to make it easier to read.
  • Renamed the package name example to make it closer to the real ones.
  • Simplified the entry to add links because the @drawable/package part was unclear.
  • Clarified in the PR template what actions to take. In particular it was not obvious that the template could be inserted into the description if you clicked on the link.

@github-actions github-actions bot added the docs Improvements or additions to documentation. label Dec 14, 2023
Copy link
Collaborator Author

@x9136 x9136 Dec 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The preview doesn't take line breaks into account, but I think it should be fine since the General change template works as espected once selected.

@Chefski Chefski merged commit 0765251 into LawnchairLauncher:develop Dec 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants