Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating and simplifying templates #1668

Merged
merged 7 commits into from
Dec 23, 2023
Merged

Updating and simplifying templates #1668

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
87e4a65
Removed [DISCUSSION] from the issue template so as not to duplicate t…
x9136 Dec 14, 2023
b2b53f0
Cleaned up the template on adding icons from duplication and clarifie…
x9136 Dec 14, 2023
bc5e696
Clarified the wording that appears when creating a PR
x9136 Dec 14, 2023
9527399
Minor fix
x9136 Dec 14, 2023
600bd06
Minor fix
x9136 Dec 14, 2023
1080f3d
Removed unnecessary part from the link to the icon addition template
x9136 Dec 15, 2023
d351d95
Swapped the order of the Updated and Linked sections, bringing up the…
x9136 Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/ISSUE_TEMPLATE/general_discussion.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
name: General Discussion
description: Discuss something related to Lawnicons.
title: "[DISCUSSION] "
labels: [discussion]
body:
- type: textarea
Expand Down
25 changes: 12 additions & 13 deletions .github/PULL_REQUEST_TEMPLATE/icon_addition.md
View file
Open in desktop
Copy link
Collaborator Author

@x9136 x9136 Dec 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The preview doesn't take line breaks into account, but I think it should be fine since the General change template works as espected once selected.

Original file line number Diff line number Diff line change
@@ -1,21 +1,20 @@
# Description
<!-- Please provide a short summary of what icons you added, changed, or linked
-->
<!-- Please provide a short summary of what icons you added, changed, or linked -->

## Icons addition information
<!-- Please specify if you added an icon that was requested in the icon request form, as seen below -->
### Icons added
* App Name (`package.name`) - added from icon request form
* App Name (`package.name`)
* App Name (`package.name`)

### Icons updated
* App Name (`package.name`)
* App Name (`package.name`)
### Added
App Name (`com.package.app`)
App Name (`com.package.app`)
App Name (`com.package.app`)

### Icons linked
* App Name (linked `package.name` to `@drawable/package`)
* App Name (linked `package.name` to `@drawable/package`)
### Updated
App Name (`com.package.app`)
App Name (`com.package.app`)

### Linked
App Name (`com.package.app` → `drawable.svg`)
App Name (`com.package.app` → `drawable.svg`)

## Contributor's checklist
<!-- Replace [ ] with [x] to check -->
Expand Down
4 changes: 2 additions & 2 deletions .github/pull_request_template.md
View file
Open in desktop
x9136 marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<!-- Please select the the `Preview` tab -->
<!-- Please open the the `Preview` tab to select a template -->

Select the appropriate sub-template:
## Click on the template that fits your PR
* [**Icon addition**](?expand=1&template=icon_addition.md&labels=needs+review,icon+change)
* [General or miscellaneous change](?expand=1&template=general_change.md)
* *[Blank](?expand=1&body=+) (not recommended)*