Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code base and tests adjustment to API_LEVEL_22 Ledger SDK #140

Merged
merged 5 commits into from
Jan 7, 2025
Merged

Code base and tests adjustment to API_LEVEL_22 Ledger SDK #140

merged 5 commits into from
Jan 7, 2025

Conversation

iartemov-ledger
Copy link
Contributor

@iartemov-ledger iartemov-ledger commented Dec 20, 2024 •
edited
Loading

Checklist

  • App update process has been followed
  • Target branch is develop
  • Application version has been bumped
  • Code: replacing nbgl_useCaseSettings() deprecated call
  • Tests: NanoS+, NanoX snapshots update (shifted with latest SDK updates)
  • Tests: Stax and Flex snapshots update (shifted with latest SDK updates)
  • Tests: TimeoutError: Timeout waiting for screen change for Stax only (required a coordinate update)

@iartemov-ledger iartemov-ledger changed the title Stax and Flex test snapshots update NanoS+, NanoX, Stax and Flex test snapshots update Dec 20, 2024
@iartemov-ledger iartemov-ledger changed the title NanoS+, NanoX, Stax and Flex test snapshots update NanoS+, NanoX, Stax and Flex tests fixes Dec 20, 2024
@iartemov-ledger iartemov-ledger changed the title NanoS+, NanoX, Stax and Flex tests fixes Code base and test adaption to API_LEVEL_22 Ledger SDK Dec 23, 2024
@iartemov-ledger iartemov-ledger changed the title Code base and test adaption to API_LEVEL_22 Ledger SDK Code base and tests adaption to API_LEVEL_22 Ledger SDK Dec 23, 2024
@iartemov-ledger iartemov-ledger changed the title Code base and tests adaption to API_LEVEL_22 Ledger SDK Code base and tests adjustment to API_LEVEL_22 Ledger SDK Dec 23, 2024
@iartemov-ledger iartemov-ledger marked this pull request as ready for review December 23, 2024 14:53
@iartemov-ledger
Copy link
Contributor Author

Should we bump the app version in this case ?

@iartemov-ledger iartemov-ledger mentioned this pull request Dec 24, 2024
Merged
5 tasks
@iartemov-ledger iartemov-ledger mentioned this pull request Jan 6, 2025
Merged
5 tasks
@iartemov-ledger
Copy link
Contributor Author

Should we bump the app version in this case ?

Offline response was yes and the version has been bumped.

tdejoigny-ledger
tdejoigny-ledger approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@tdejoigny-ledger tdejoigny-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test for the settings to add in another PR

@iartemov-ledger
Copy link
Contributor Author

test for the settings to add in another PR

FYI @tdejoigny-ledger it'll be in #142

@iartemov-ledger iartemov-ledger merged commit 7abd9c6 into LedgerHQ:develop Jan 7, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdejoigny-ledger tdejoigny-ledger tdejoigny-ledger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iartemov-ledger @tdejoigny-ledger