Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code base and tests adjustment to API_LEVEL_22 Ledger SDK #140

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

All notable changes to this project will be documented in this file.

## 2.0.1 - 2025-01-02

- Update to Ledger SDK API_LEVEL_22, deprecated API replacement

## 2.0.0 - 2024-05-01

- Support of Flex device
Expand Down
6 changes: 3 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#*******************************************************************************
# Ledger App Monero
# (c) 2023 Ledger SAS.
#
# (c) 2023-2025 Ledger SAS.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
Expand Down Expand Up @@ -29,7 +29,7 @@ APPNAME = "Monero"
# Application version
APPVERSION_M = 2
APPVERSION_N = 0
APPVERSION_P = 0
APPVERSION_P = 1
APPVERSION = "$(APPVERSION_M).$(APPVERSION_N).$(APPVERSION_P)"

SPECVERSION = "1.0"
Expand Down
11 changes: 6 additions & 5 deletions src/monero_ux_nbgl_menu.c
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@

#define PAGE_START 0
#define NB_PAGE_SETTING 3
#define IS_TOUCHABLE true

void __attribute__((noreturn)) app_exit(void);

Expand Down Expand Up @@ -201,12 +200,14 @@ static void settings_control_cb(int token, uint8_t index, int page) {
UNUSED(page);
switch (token) {
case ACCOUNT_TOKEN:
nbgl_useCaseSettings("Select account", 0, 3, IS_TOUCHABLE, display_settings_menu,
account_settings_navigation_cb, account_settings_control_cb);
nbgl_useCaseNavigableContent("Select account", 0, 3, display_settings_menu,
account_settings_navigation_cb,
account_settings_control_cb);
break;
case NETWORK_TOKEN:
nbgl_useCaseSettings("Select network", 0, 2, IS_TOUCHABLE, display_settings_menu,
network_settings_navigation_cb, network_settings_control_cb);
nbgl_useCaseNavigableContent("Select network", 0, 2, display_settings_menu,
network_settings_navigation_cb,
network_settings_control_cb);
break;
case RESET_TOKEN:
nbgl_useCaseConfirm("Reset account\ninformations ?", "", "Yes, Reset", "Go back",
Expand Down
2 changes: 1 addition & 1 deletion tests/monero_client/monero_crypto_cmd.py
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ def display_address(self, test_name, firmware, navigator, derivation: bytes, out
else:
instructions = [
NavIns(NavInsID.SWIPE_CENTER_TO_LEFT),
NavIns(NavInsID.TOUCH, (200, 350 if firmware.device.startswith("flex") else 410)),
NavIns(NavInsID.TOUCH, (200, 350 if firmware.device.startswith("flex") else 375)),
NavIns(NavInsID.USE_CASE_ADDRESS_CONFIRMATION_EXIT_QR),
NavIns(NavInsID.SWIPE_CENTER_TO_LEFT),
NavIns(NavInsID.USE_CASE_ADDRESS_CONFIRMATION_CONFIRM),
Expand Down
Binary file modified tests/snapshots/flex/test_display_address/00000.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/flex/test_display_address/00001.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/flex/test_display_address/00002.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/flex/test_display_address/00003.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/flex/test_display_address/00004.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/flex/test_display_address/00006.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/flex/test_display_subaddress/00000.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/flex/test_display_subaddress/00001.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/flex/test_display_subaddress/00002.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/flex/test_display_subaddress/00003.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/flex/test_display_subaddress/00004.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/flex/test_display_subaddress/00006.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/flex/test_prefix_hash_hash_init/00000.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/flex/test_private_view_key/00000.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/flex/test_validate_prehash_update/00001.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/flex/test_validate_prehash_update/00002.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/nanosp/test_display_address/00001.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/nanosp/test_display_address/00002.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/nanosp/test_display_address/00003.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/nanosp/test_display_subaddress/00001.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/nanosp/test_display_subaddress/00002.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/nanosp/test_display_subaddress/00003.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/nanosp/test_prefix_hash_hash_init/00002.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/nanosp/test_validate_prehash_init/00002.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/nanosp/test_validate_prehash_update/00001.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/nanosp/test_validate_prehash_update/00002.png
Binary file modified tests/snapshots/nanox/test_display_address/00001.png
Binary file modified tests/snapshots/nanox/test_display_address/00002.png
Binary file modified tests/snapshots/nanox/test_display_address/00003.png
Binary file modified tests/snapshots/nanox/test_display_subaddress/00001.png
Binary file modified tests/snapshots/nanox/test_display_subaddress/00002.png
Binary file modified tests/snapshots/nanox/test_display_subaddress/00003.png
Binary file modified tests/snapshots/nanox/test_prefix_hash_hash_init/00002.png
Binary file modified tests/snapshots/nanox/test_validate_prehash_init/00002.png
Binary file modified tests/snapshots/nanox/test_validate_prehash_update/00001.png
Binary file modified tests/snapshots/nanox/test_validate_prehash_update/00002.png
Binary file modified tests/snapshots/stax/test_display_address/00000.png
Binary file modified tests/snapshots/stax/test_display_address/00001.png
Binary file modified tests/snapshots/stax/test_display_address/00002.png
Binary file modified tests/snapshots/stax/test_display_address/00003.png
Binary file modified tests/snapshots/stax/test_display_address/00004.png
Binary file modified tests/snapshots/stax/test_display_address/00005.png
Binary file modified tests/snapshots/stax/test_display_address/00006.png
Binary file modified tests/snapshots/stax/test_display_subaddress/00000.png
Binary file modified tests/snapshots/stax/test_display_subaddress/00001.png
Binary file modified tests/snapshots/stax/test_display_subaddress/00002.png
Binary file modified tests/snapshots/stax/test_display_subaddress/00003.png
Binary file modified tests/snapshots/stax/test_display_subaddress/00004.png
Binary file modified tests/snapshots/stax/test_display_subaddress/00005.png
Binary file modified tests/snapshots/stax/test_display_subaddress/00006.png
Binary file modified tests/snapshots/stax/test_prefix_hash_hash_init/00000.png
Binary file modified tests/snapshots/stax/test_prefix_hash_hash_init/00001.png
Binary file modified tests/snapshots/stax/test_private_view_key/00000.png
Binary file modified tests/snapshots/stax/test_private_view_key/00001.png
Binary file modified tests/snapshots/stax/test_validate_prehash_update/00000.png
Binary file modified tests/snapshots/stax/test_validate_prehash_update/00001.png
Binary file modified tests/snapshots/stax/test_validate_prehash_update/00002.png
Loading