Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing API or feature for Nano on NBGL #838

Merged
merged 20 commits into from
Jan 27, 2025

Conversation

cedelavergne-ledger
Copy link
Contributor

@cedelavergne-ledger cedelavergne-ledger commented Jan 3, 2025

In the context of porting Nano Apps on NBGL, we need to add or adapt some functions:

  • Add missing API nbgl_useCaseKeypadDigits & nbgl_useCaseKeypadPIN
  • Add Vertical Navigation for CHOICES_LIST & BARS_LIST under compilation flags
  • Add new content types: CENTERED_INFO, INFO_BUTTON, BARS_LIST & CHOICE_LIST
  • Optimize and factorize code
  • Add missing API nbgl_useCaseGenericReview
  • Add missing API nbgl_useCaseNavigableContent
  • Add support for action in Home&Settings
  • Optimize displayStreamingReviewPage
  • Add missing API nbgl_useCaseReviewStreamingBlindSigningStart - factorize code
  • Add support of reviewSubTitle in streaming review
  • Add missing API nbgl_useCaseReviewBlindSigning
  • Add missing API nbgl_useCaseConfirm - support modal screens
  • Improve nbgl_useCaseStatus to support icon display
  • Add missing API nbgl_useCaseGenericSettings & nbgl_useCaseGenericConfiguration
  • Add missing API nbgl_useCaseGetNbxxx
  • Fix nbgl_useCaseAddressReview when called with additional tags
  • Add missing file nbgl_step for compilation

Note: nbgl_useCaseKeypadxxx need API_LEVEL 23

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.43%. Comparing base (8aa0037) to head (d23e0b9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #838   +/-   ##
=======================================
  Coverage   60.43%   60.43%           
=======================================
  Files          13       13           
  Lines        1820     1820           
=======================================
  Hits         1100     1100           
  Misses        720      720           
Flag Coverage Δ
unittests 60.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lib_nbgl/src/nbgl_use_case_nanos.c Outdated Show resolved Hide resolved
lib_nbgl/src/nbgl_use_case_nanos.c Outdated Show resolved Hide resolved
@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA-1584-nbgl_nano branch 5 times, most recently from 3d31b00 to bcbd356 Compare January 24, 2025 11:45
lib_nbgl/doc/mainpage_nanos.dox Outdated Show resolved Hide resolved
lib_nbgl/doc/nbgl_layout.dox Outdated Show resolved Hide resolved
lib_nbgl/doc/nbgl_layout_nanos.dox Outdated Show resolved Hide resolved
@cedelavergne-ledger cedelavergne-ledger merged commit 4130d31 into master Jan 27, 2025
183 checks passed
@cedelavergne-ledger cedelavergne-ledger deleted the cev/B2CA-1584-nbgl_nano branch January 27, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants