-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing API or feature for Nano on NBGL #838
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #838 +/- ##
=======================================
Coverage 60.43% 60.43%
=======================================
Files 13 13
Lines 1820 1820
=======================================
Hits 1100 1100
Misses 720 720
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Jan 6, 2025
cedelavergne-ledger
force-pushed
the
cev/B2CA-1584-nbgl_nano
branch
3 times, most recently
from
January 13, 2025 15:19
feb1594
to
0132c76
Compare
cedelavergne-ledger
force-pushed
the
cev/B2CA-1584-nbgl_nano
branch
5 times, most recently
from
January 21, 2025 09:30
07ab16d
to
10aa9d6
Compare
cedelavergne-ledger
requested review from
agrojean-ledger and
nroggeman-ledger
January 22, 2025 15:18
cedelavergne-ledger
force-pushed
the
cev/B2CA-1584-nbgl_nano
branch
5 times, most recently
from
January 24, 2025 11:45
3d31b00
to
bcbd356
Compare
cedelavergne-ledger
force-pushed
the
cev/B2CA-1584-nbgl_nano
branch
from
January 24, 2025 14:58
bcbd356
to
ed8dc77
Compare
- Fix additional tags handling (PIC) - Align STATUS_TYPE_ADDRESS_REJECTED message with Stax/Flex
cedelavergne-ledger
force-pushed
the
cev/B2CA-1584-nbgl_nano
branch
from
January 24, 2025 16:44
ed8dc77
to
1fcbe60
Compare
cedelavergne-ledger
force-pushed
the
cev/B2CA-1584-nbgl_nano
branch
from
January 27, 2025 08:50
1fcbe60
to
95281bf
Compare
nroggeman-ledger
requested changes
Jan 27, 2025
cedelavergne-ledger
force-pushed
the
cev/B2CA-1584-nbgl_nano
branch
from
January 27, 2025 11:46
95281bf
to
d23e0b9
Compare
nroggeman-ledger
approved these changes
Jan 27, 2025
This was referenced Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of porting Nano Apps on NBGL, we need to add or adapt some functions:
nbgl_useCaseKeypadDigits
&nbgl_useCaseKeypadPIN
CHOICES_LIST
&BARS_LIST
under compilation flagsCENTERED_INFO
,INFO_BUTTON
,BARS_LIST
&CHOICE_LIST
nbgl_useCaseGenericReview
nbgl_useCaseNavigableContent
action
in Home&SettingsdisplayStreamingReviewPage
nbgl_useCaseReviewStreamingBlindSigningStart
- factorize codereviewSubTitle
in streaming reviewnbgl_useCaseReviewBlindSigning
nbgl_useCaseConfirm
- supportmodal
screensnbgl_useCaseStatus
to support icon displaynbgl_useCaseGenericSettings
&nbgl_useCaseGenericConfiguration
nbgl_useCaseGetNbxxx
nbgl_useCaseAddressReview
when called with additional tagsnbgl_step
for compilationNote: nbgl_useCaseKeypadxxx need API_LEVEL 23