Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement reflection #4

Merged
merged 5 commits into from
Aug 14, 2024
Merged

feat: implement reflection #4

merged 5 commits into from
Aug 14, 2024

Conversation

Zurcusa
Copy link
Collaborator

@Zurcusa Zurcusa commented Aug 13, 2024

No description provided.

@Zurcusa
Copy link
Collaborator Author

Zurcusa commented Aug 13, 2024

The idea behind this PR is to move away from using JS overlay classes when they are actually not needed and stick to Java classes. This means we won't need TeaVM's JSON object to serialize/deserialize jsons.

If this is merged all http requests that were meant to work with JSON.stringify(JSObject) can now directly take a json string as a parameter and also return the json string as a result.

Copy link
Member

@ablax ablax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just please remove the usage of DivLogger

Zurcusa and others added 2 commits August 14, 2024 15:57
* feat: add functionality to interact with localStorage.

* refactor: remove deprecated LocalStorage bean.

* refactor: address pr comments
@Zurcusa Zurcusa merged commit 64b0339 into dev Aug 14, 2024
1 check passed
@Zurcusa Zurcusa deleted the implement-reflection branch August 14, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants