Additional diann fdr #291
Open
Additional diann fdr #291
+280
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This reverts commit 242fdb9.
mschwoer
commented
Jan 24, 2025
| @@ -57,7 +58,7 @@ def create_anndata(self) -> ad.AnnData: | |||
| index=PsmDfCols.RAW_NAME, | |||
| columns=PsmDfCols.PROTEINS, | |||
| values=PsmDfCols.INTENSITY, | |||
| aggfunc="first", | |||
| aggfunc="first", # DataFrameGroupBy.first -> will skip NA | |||
There was a problem hiding this comment.
@vbrennsteiner I looked up the docs, seem that this logic (https://github.com/MannLabs/bm_tools/blob/main/bm_tools/diann.py#L184) is implied in "first"?
There was a problem hiding this comment.
I couldn't find the respective documentation, but I changed this in bm_tools and the test with na-containing reports still works, thanks for the hint! :)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add additional filtering for DIANN FDR.