Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on top of #60, this is a more fundamental way of fixing the interaction with our token contracts
closes #56
the issue
with
state.get()
orstate.getAndRequireEquals()
, we were using o1js' lazy fetch mechanism which was a workaround for the fact that circuits could not be async. in the present case, the lazy fetch mechanism was broken, because the account to be fetched is only known after another account was fetched. in tests, this showed up as trying to fetch a dummy public key instead of the actual account, and not having the actual account later on.solution
now that o1js supports async circuits, we no longer have to rely on the workaround. instead, we fetch the current admin public key directly inside a
Provable.witnessAsync()
block, and add a precondition for it using.requireEquals()
.