Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix concurrent transfer better #61

Merged
merged 1 commit into from
Jun 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions FungibleToken.ts
Original file line number Diff line number Diff line change
Expand Up @@ -76,13 +76,20 @@ export class FungibleToken extends TokenContract implements FungibleTokenLike {
this.actionState.set(Reducer.initialActionState)
}

public getAdminContract(): FungibleTokenAdminBase {
return (new FungibleToken.adminContract(this.admin.getAndRequireEquals()))
public async getAdminContract(): Promise<FungibleTokenAdminBase> {
const admin = await Provable.witnessAsync(PublicKey, async () => {
let pk = await this.admin.fetch()
assert(pk !== undefined, "could not fetch admin contract key")
return pk
})
this.admin.requireEquals(admin)
return (new FungibleToken.adminContract(admin))
}

@method
async setAdmin(admin: PublicKey) {
const canChangeAdmin = await this.getAdminContract().canChangeAdmin(admin)
const adminContract = await this.getAdminContract()
const canChangeAdmin = await adminContract.canChangeAdmin(admin)
canChangeAdmin.assertTrue()
this.admin.set(admin)
this.emitEvent("SetAdmin", admin)
Expand All @@ -92,8 +99,8 @@ export class FungibleToken extends TokenContract implements FungibleTokenLike {
async mint(recipient: PublicKey, amount: UInt64) {
this.paused.getAndRequireEquals().assertFalse()
const accountUpdate = this.internal.mint({ address: recipient, amount })
const canMint = await this.getAdminContract()
.canMint(accountUpdate)
const adminContract = await this.getAdminContract()
const canMint = await adminContract.canMint(accountUpdate)
canMint.assertTrue()
this.approve(accountUpdate)
this.emitEvent("Mint", new MintEvent({ recipient, amount }))
Expand All @@ -112,14 +119,16 @@ export class FungibleToken extends TokenContract implements FungibleTokenLike {

@method
async pause() {
const canPause = await this.getAdminContract().canPause()
const adminContract = await this.getAdminContract()
const canPause = await adminContract.canPause()
canPause.assertTrue()
this.paused.set(Bool(true))
}

@method
async resume() {
const canResume = await this.getAdminContract().canResume()
const adminContract = await this.getAdminContract()
const canResume = await adminContract.canResume()
canResume.assertTrue()
this.paused.set(Bool(false))
}
Expand Down
20 changes: 13 additions & 7 deletions FungibleTokenAdmin.ts
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
import {
AccountUpdate,
assert,
Bool,
DeployArgs,
method,
Provable,
PublicKey,
SmartContract,
State,
state,
UInt64,
} from "o1js"

export type FungibleTokenAdminBase = SmartContract & {
Expand Down Expand Up @@ -38,32 +39,37 @@ export class FungibleTokenAdmin extends SmartContract implements FungibleTokenAd
this.adminPublicKey.set(props.adminPublicKey)
}

private ensureAdminSignature() {
const admin = this.adminPublicKey.getAndRequireEquals()
private async ensureAdminSignature() {
const admin = await Provable.witnessAsync(PublicKey, async () => {
let pk = await this.adminPublicKey.fetch()
assert(pk !== undefined, "could not fetch admin public key")
return pk
})
this.adminPublicKey.requireEquals(admin)
return AccountUpdate.createSigned(admin)
}

@method.returns(Bool)
public async canMint(_accountUpdate: AccountUpdate) {
this.ensureAdminSignature()
await this.ensureAdminSignature()
return Bool(true)
}

@method.returns(Bool)
public async canChangeAdmin(_admin: PublicKey) {
this.ensureAdminSignature()
await this.ensureAdminSignature()
return Bool(true)
}

@method.returns(Bool)
public async canPause(): Promise<Bool> {
this.ensureAdminSignature()
await this.ensureAdminSignature()
return Bool(true)
}

@method.returns(Bool)
public async canResume(): Promise<Bool> {
this.ensureAdminSignature()
await this.ensureAdminSignature()
return Bool(true)
}
}
3 changes: 1 addition & 2 deletions examples/concurrent-transfer.eg.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { AccountUpdate, fetchAccount, Mina, PrivateKey, PublicKey, UInt64, UInt8 } from "o1js"
import { AccountUpdate, Mina, PrivateKey, PublicKey, UInt64, UInt8 } from "o1js"
import { FungibleToken, FungibleTokenAdmin } from "../index.js"

const url = "https://proxy.devnet.minaexplorer.com/graphql"
Expand Down Expand Up @@ -100,7 +100,6 @@ const deployTxResult = await deployTx.send().then((v) => v.wait())
console.log("Deploy tx:", deployTxResult.hash)

console.log("Minting new tokens to Alexa.")
await fetchAccount({ publicKey: admin.publicKey }) // hack to ensure the admin account is fetched
const mintTx = await Mina.transaction({
sender: feepayer.publicKey,
fee,
Expand Down