Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gtfs-realtime.proto for GTFS-ServiceChanges v3.1 #47

Closed

Conversation

lionel-nj
Copy link

@lionel-nj lionel-nj commented Jan 30, 2020

Do not merge - work in progress

This PR updates the gtfs-realtime.proto file to include new entities defined in GTFS-ServiceChanges v3.1:
https://bit.ly/gtfs-service-changes-v3_1

Draft bindings for this proto are available at MobilityData/gtfs-realtime-bindings#58.

NOT FOR PRODUCTION USE - FOR PROTOYPING ONLY

Contents are still subject to change.

If you start using this .proto file, please comment below!

Lionel N added 6 commits January 30, 2020 15:39
Adds StopTimeProperties
Adds VehicleProperties
Adds WheelchairAccessibleStatus
Adds BikesAllowedStatus
Extends StopTimeUpdate
Extends StopTimeEvent
Adds PickupType
Adds DropOffType
Adds Shape
Adds ShapePointExtends TripProperties
Adds Route
Adds RouteType
Extends TripProperties
Adds stop
Adds WheelchairBoardingStatus
Extends StopTimeProperties
@lionel-nj lionel-nj requested review from barbeau, LeoFrachet and a user January 30, 2020 22:22
@lionel-nj lionel-nj self-assigned this Jan 30, 2020
@LeoFrachet
Copy link

#46

@lionel-nj lionel-nj changed the title Fix #46 Update .proto file in order to match the bindings set by v3.1 of service changes Feb 3, 2020
Copy link
Member

@barbeau barbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lionel-nj Thanks for your work on this! Generally speaking it looks pretty good. Some requested changes are in-line with comments.

gtfs-realtime/proto/gtfs-realtime.proto Show resolved Hide resolved
gtfs-realtime/proto/gtfs-realtime.proto Outdated Show resolved Hide resolved
gtfs-realtime/proto/gtfs-realtime.proto Outdated Show resolved Hide resolved
gtfs-realtime/proto/gtfs-realtime.proto Outdated Show resolved Hide resolved
gtfs-realtime/proto/gtfs-realtime.proto Outdated Show resolved Hide resolved
gtfs-realtime/proto/gtfs-realtime.proto Outdated Show resolved Hide resolved
gtfs-realtime/proto/gtfs-realtime.proto Outdated Show resolved Hide resolved
gtfs-realtime/proto/gtfs-realtime.proto Outdated Show resolved Hide resolved
gtfs-realtime/proto/gtfs-realtime.proto Outdated Show resolved Hide resolved
gtfs-realtime/proto/gtfs-realtime.proto Outdated Show resolved Hide resolved
Lionel N added 8 commits February 5, 2020 12:07
-changes MUST_PHONE_AGENCY to MUST_PHONE_AGENCY_PICKUP
-changes MUST_ASK_DRIVER to MUST_ASK_DRIVER_PICKUP
-adds MUST_PHONE_AGENCY_DROP_OFF
-adds MUST_ASK_DRIVER_DROP_OFF
-changes  MUST_PHONE_AGENCY to MUST_PHONE_AGENCY_PICKUP
-changes MUST_ASK_DRIVER to MUST_ASK_DRIVER_PICK_UP
-adds MUST_PHONE_AGENCY_DROP_OFF
-adds MUST_ASK_DRIVER_DROP_OFF
-add extra space after comment marks
-delete "or empty" for fields that have a default value
-change PICK_UP -> PICKUP
@lionel-nj lionel-nj requested a review from barbeau February 27, 2020 15:05
Lionel N and others added 4 commits April 10, 2020 15:23
…num RouteType in static GTFS dataset validator
This allows specifying a new trip (not in CSV GTFS) that can be repeated across multiple dates

See #47 (comment)
Make it easier to discover which trips replace a given scheduled trip which is CANCELED by moving the field to the trip that is canceled
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 12, 2022
@barbeau
Copy link
Member

barbeau commented Feb 15, 2022

Not stale

@github-actions github-actions bot removed the stale label Feb 16, 2022
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 24, 2022
@isabelle-dr
Copy link

not stale

@github-actions github-actions bot removed the stale label Apr 29, 2022
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label May 23, 2022
@isabelle-dr
Copy link

not stale

@github-actions github-actions bot removed the stale label May 25, 2022
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jun 18, 2022
@barbeau barbeau removed the stale label Jun 18, 2022
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jul 12, 2022
@github-actions
Copy link

This pull request has been closed due to inactivity. Pull requests can always be reopened after they have been closed. See the Specification Amendment Process.

@github-actions github-actions bot closed this Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale work-in-progress A work-in-progress pull request that shouldn't be merged yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants