-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gtfs-realtime.proto for GTFS-ServiceChanges v3.1 #47
Update gtfs-realtime.proto for GTFS-ServiceChanges v3.1 #47
Conversation
Adds StopTimeProperties Adds VehicleProperties Adds WheelchairAccessibleStatus Adds BikesAllowedStatus Extends StopTimeUpdate Extends StopTimeEvent Adds PickupType Adds DropOffType
Adds Shape Adds ShapePointExtends TripProperties
Adds Route Adds RouteType Extends TripProperties
Adds stop Adds WheelchairBoardingStatus Extends StopTimeProperties
#46 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lionel-nj Thanks for your work on this! Generally speaking it looks pretty good. Some requested changes are in-line with comments.
-changes MUST_PHONE_AGENCY to MUST_PHONE_AGENCY_PICKUP -changes MUST_ASK_DRIVER to MUST_ASK_DRIVER_PICKUP -adds MUST_PHONE_AGENCY_DROP_OFF -adds MUST_ASK_DRIVER_DROP_OFF -changes MUST_PHONE_AGENCY to MUST_PHONE_AGENCY_PICKUP -changes MUST_ASK_DRIVER to MUST_ASK_DRIVER_PICK_UP -adds MUST_PHONE_AGENCY_DROP_OFF -adds MUST_ASK_DRIVER_DROP_OFF
Based on the .proto from MobilityData/transit#47
-add extra space after comment marks -delete "or empty" for fields that have a default value -change PICK_UP -> PICKUP
…num RouteType in static GTFS dataset validator
…https://github.com/MobilityData/transit into update-proto-to-match-bindings-of-ServiceChangesv3.1
This allows specifying a new trip (not in CSV GTFS) that can be repeated across multiple dates See #47 (comment)
Make it easier to discover which trips replace a given scheduled trip which is CANCELED by moving the field to the trip that is canceled
See: * Allow repeated start_date for new Trips - MobilityData/transit@e30983f * Trip.replaces_trip_id -> TripUpdate.replaced_by_trip_id - MobilityData/transit@9c5af29
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Not stale |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
not stale |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
not stale |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been closed due to inactivity. Pull requests can always be reopened after they have been closed. See the Specification Amendment Process. |
Do not merge - work in progress
This PR updates the gtfs-realtime.proto file to include new entities defined in GTFS-ServiceChanges v3.1:
https://bit.ly/gtfs-service-changes-v3_1
Draft bindings for this proto are available at MobilityData/gtfs-realtime-bindings#58.
NOT FOR PRODUCTION USE - FOR PROTOYPING ONLY
Contents are still subject to change.
If you start using this .proto file, please comment below!