Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gtfs-realtime.proto for GTFS-ServiceChanges v3.1 #47
Update gtfs-realtime.proto for GTFS-ServiceChanges v3.1 #47
Changes from all commits
76cfb4e
2dcc08f
a2986db
b19e8c1
41890a9
e0d17ec
4ba82c1
720fa69
46eb2eb
4bafb66
e291dfd
284ae00
9f4f693
c3257ed
e61dd55
1b45797
a3d59e5
536a993
6419c8e
e2d483a
6e75483
4c2a43a
e70f138
b7e22c4
3638d41
281af87
020d4da
e30983f
9c5af29
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, the proposal specifies epoch (therefore uint64) but comments propose HH:MM:SS format (see https://docs.google.com/document/d/1oPfQ6Xvui0g3xiy1pNiyu5cWFLhvrTVyvYsMVKGyGWM/edit?disco=AAAAD25IX2g).
Just making sure that we should keep the HH:MM:SS format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we should keep "HH:MM:SS". @scmccallum and @timMillet are working to update the spec document to reflect "HH:MM:SS".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you represent the dates the trip is running? Maybe a
start_date
onTrip
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paulswartz Yes, I believe the date would be represented in
trip.start_date
inTripDescriptor
. AllTrip
entities refer to single trip instance.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, whoops, not
TripDescriptor
, we're not re-using that forTrip
. It would be a new fieldTrip.start_date
that's not currently in the document.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For anyone looking at this thread but hasn't looked at the Google Doc - one reason for preferring "HH:MM:SS" is to be able to specify frequency-based trips as well. To support this, there will be more fields added soon to mirror GTFS static CSV frequencies.txt (but only for exact_times=0 trips).