-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added favicon and some additional files #10
Conversation
Hope that you have followed the contribution guidelines :-) (Powered by GitMate.io) |
PR regarding #2 |
All Submissions:
New Feature Submissions:
Changes to Core Features:
|
The local host is working fine right @harry-hov ? |
With some more screenshots of the new layout , this PR will be ready to get merged✌ |
yeah, i checked |
@harry-hov. Squash all your commits into one.Give it a suitable message in an imperative mood. |
Ok fine. Just squash up your commits |
it means making patch ? |
Look here |
its my first encounter with rebase. what to do after opening rebase editor. type a new commit msg ? @monsij |
Yes.after you have all your changes under 1 commit, give it a short title |
and after giving short title, send PR again? |
This same PR |
so its done @monsij ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess Change of Bootstrap (Typo) already fixed, Did you try rebasing your repo?
@harry-hov : henceforth make PR from a branch of your fork . This time its fine. 😁 |
ack |
"@gitmate-bot rebase" |
Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently |
Automated rebase with GitMate.io was successful! 🎉 |
ack |
learned a lot from this like about rebase and squash. |
What Changes i did ?
1, Added favicon
Need : Its a small change but makes site more attractive. (as i'm working on its makeover)
2. Changed location of main.css and added some new files
Changes are in
StudentPortal> pro1> blog> static
Need : These files are required to makeover and redesign some html pages. (may be unfinished, but does not affect working of project).
Why I'm pushing this now? so everyone will get new location of main.css
3. Typo error
in settings.py, line no. 131
bootstrp4 -> bootstrap4
Need : because without this fix project is not working on localhost. So in order run it on localhost i fix this.