-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for syndat_getjtbul code parsing 3-character storm names (GFSv16.3.21) #3200
Fix for syndat_getjtbul code parsing 3-character storm names (GFSv16.3.21) #3200
Conversation
The gfs_atmos_tropcy_qc_reloc did not properly parse the vitals info from a raw bulletin with a tab in the storm name field for storm "SIX". The code sorc/syndat_getjtbul.fd/getjtbul.d converting a tab to a space worked well for storms that have at least 4 characters in their names, but does not work as well for storms with 3-character names. This code change will fix the parsing problem for 3-character storms. Refs NOAA-EMC#2591
sorc/syndat_getjtbul.fd/getjtbul.f
Outdated
DUMY2K(20:80) = INL(17:77) | ||
INL= DUMY2K | ||
PRINT *, ' ' | ||
PRINT *, '==> This is an new-format record with a 4-digit ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor note. This should probably read
PRINT *, '==> This is a new-format record with a 4-digit year'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comment @DavidHuber-NOAA ! @Qingfu-Liu shall I make the suggested change from Dave?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a comment on a print statement, but approving as-is.
Kate, |
@Qingfu-Liu My terminal shows that adding "year" to the print statement hits the fortan character limit of 72 characters per line. I added the "year" text as a line continuation. It's been a while since I modified fortran so please see the following git diff and let me know if it looks correct? I added "year" to several print statements that needed it:
|
Hi Kate, |
@Qingfu-Liu Even better, thanks! I committed those comment changes @ 1cee9a0. I will now proceed with merging this PR, cutting a new hand-off tag, and letting NCO. Thanks! |
65f2645
into
NOAA-EMC:release/gfs.v16.3.21
…release/gfs.v16.3.22 * origin/release/gfs.v16.3.21: Fix for syndat_getjtbul code parsing 3-character storm names (GFSv16.3.21) (#3200)
Description
This PR introduces an update to the
sorc/syndat_getjtbul.fd/getjtbul.f
code to resolve a problem parsing 3-character storm names. This update is being included in the GFSv16.3.21 package (with approval by NCO).From the developer @Qingfu-Liu:
Refs #2591
Type of change
Change characteristics
Update to code that lives within global-workflow branch.
How has this been tested?
Tested by NCO and developer