Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port delp_total diagnostic to public version of SHiELD #316

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

spencerkclark
Copy link
Member

@spencerkclark spencerkclark commented Jan 24, 2024

Description

This PR adds a diagnostic for the pressure thickness which includes the mass of water condensates (delp_total). This is the actual pressure thickness used internally by the dynamical core to define things like tracer mixing ratios, and so it is useful to be able to output it for diagnosing budgets. In many ways it is a simpler diagnostic to implement than the existing delp diagnostic.

xref: I implemented this diagnostic as part of another merge request to the internal version of SHiELD (see this commit; note authentication is needed to access the link).

Since this is such a simple change, and one that already exists in the internal version of SHiELD, I hope we can review / merge it quickly, as I need it for a new simulation. Thanks!

cc: @lharris4 and @bensonr

How Has This Been Tested?

I tested this in a short C12 resolution simulation within a Docker container, and validated that I could reproduce the existing delp diagnostic using this new delp_total diagnostic and the sum of the condensate tracers (notebook).

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@lharris4 lharris4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, thank you. Note that if GFS_PHYS is not defined then delp_dycore and delp are identical: the version used when GFS_PHYS is defined is to match the moist mass (no condensates) used in the Legacy GFS and expected by downstream applications of the GFS.

@bensonr bensonr self-requested a review January 24, 2024 14:51
tools/fv_diagnostics.F90 Outdated Show resolved Hide resolved
@bensonr bensonr requested a review from lharris4 January 24, 2024 20:11
Copy link
Contributor

@lharris4 lharris4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple is good. Thanks for making these changes.

@spencerkclark spencerkclark mentioned this pull request Jan 25, 2024
6 tasks
@bensonr bensonr merged commit e3fc72b into NOAA-GFDL:main Jan 25, 2024
74 checks passed
@spencerkclark spencerkclark deleted the port-delp_dycore branch January 25, 2024 21:08
@spencerkclark spencerkclark changed the title Port delp_dycore diagnostic to public version of SHiELD Port delp_total diagnostic to public version of SHiELD Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants