Rework camera logic #232
Open
Rework camera logic #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y the simulation to be able to work with the old and new camera type
…initial orientation
stimpfli
requested review from
sibocw and
tkclam
and removed request for
sibocw
sibocw
requested changes
Jan 16, 2025
There was a problem hiding this comment.
Thanks a lot for this significant undertaking!
- Could you please update
doc/source/api_ref/camera.rstaccordingly? This involves:- Edit the text explanation if needed
- Add the autogenerated documentation for all camera types)?
For ii, you can use
.. automodule:: flygym.camera :members: :undoc-members: :show-inheritance:... instead of adding all cameras explicitly:
.. autoclass:: flygym.camera.Camera :members: :undoc-members: :show-inheritance: .. autoclass:: flygym.camera.ZStabCamera :members: :undoc-members: :show-inheritance: ... etc ...See https://github.com/NeLy-EPFL/flygym/blob/rework-camera/doc/source/api_ref/legacy.rst for an example.
- For all notebooks changed, can you also modify the RST files under
doc/source/tutorialsaccordingly? I know... this is tedious. I also had to manually modify the RST files generated by nbconvert.
…to targeted_fly_names and make it a list of str
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements generic camera that can be attached to any part of the model.
Cameras are now initialised dynamically and not part of the xml.
New cameras with special update rules can be created and inherit from the base camera class.
Changes have been incorporated to every example and notebook and tested.
Does this address any currently open issues?
[#229]