fix(coova-chilli): enforce HTTP/1.1 for curl compatibility #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need an issue to go with this, feel free to add one I'll fix the CI right away (server is busy) |
|
Make sure your changes are rebased against OpenWRT 24.10 |
Introduce a patch to enforce HTTP/1.1 in CoovaChilli's curl requests. This change ensures compatibility with servers requiring explicit HTTP version declaration. Avoid a bug with libcurl and HTTP/2: ``` Feb 10 11:42:08 box : curl error HTTP/2 stream 11 was not closed cleanly: PROTOCOL_ERROR (err 1) ```
Refactor debug logging in the coova-chilli proxy to ensure it respects the `_options.debug` flag. This replaces direct `_debug_` checks with conditional logging based on the runtime debug configuration.
Amygos
force-pushed
the
fix_chilli_http11
branch
from
d5dcdb7 to
f6789a2
Compare
|
Missing the issue related, this is needed for testing purposes |
Tbaile
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two reliability and compatibility improvements in the
coova-chilli proxy:
Refactored debug logging to honor the runtime
_options.debugflaginstead of compile-time
_debug_checks. This ensures debug output isdynamically controllable during operation, avoiding unnecessary logs when
debugging is disabled.
Enforced HTTP/1.1 in curl requests to resolve protocol errors (e.g.,
HTTP/2 stream not closed cleanly) caused by servers incompatible withHTTP/2. Explicitly setting the version prevents unpredictable failures and
improves compatibility with legacy systems