Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-21.11] vengi-tools: 0.0.14 -> 0.0.18 and related changes #158116

Merged
merged 6 commits into from
Mar 2, 2022
Merged

[Backport release-21.11] vengi-tools: 0.0.14 -> 0.0.18 and related changes #158116

merged 6 commits into from
Mar 2, 2022

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Feb 4, 2022 •
edited
Loading

Motivation for this change

#158094 (comment) cc @turion

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

fgaz added 4 commits February 4, 2022 13:53
@fgaz
vengi-tools: 0.0.14 -> 0.0.17
05f521f 
(cherry picked from commit e175845)
@fgaz
vengi-tools: add convert all formats test
9ada914 
(cherry picked from commit 8ed1c05)
@fgaz
vengi-tools: remove failing roundtrip test
7c9dbcb 
(cherry picked from commit 50dae31)
@fgaz
vengi-tools: update repo and website URLs
277f69f 
engine -> vengi

(cherry picked from commit 97c0ce6)
@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label Feb 4, 2022
@fgaz
Copy link
Member Author

fgaz commented Feb 4, 2022

ofborg bot added the ofborg-internal-error label 1 minute ago

...did I do something wrong?

@fgaz
Copy link
Member Author

fgaz commented Feb 7, 2022

@GrahamcOfBorg eval

@turion
Copy link
Contributor

turion commented Feb 7, 2022

This looks fine to me, but I've never merged a nontrivial backport PR, so I'd like to have some other committer's opinion.

@cole-h cole-h removed the ofborg-internal-error Ofborg encountered an error label Feb 8, 2022
@cole-h
Copy link
Member

cole-h commented Feb 8, 2022

ofborg bot added the ofborg-internal-error label 1 minute ago

...did I do something wrong?

Nah, this is usually something GitHub did (i.e. sending API responses without required fields). It's just labeled so I can (eventually) check it out and make sure that's what it is, and not some silent API changes we'll have to accommodate.

@fgaz fgaz mentioned this pull request Feb 14, 2022
Merged
13 tasks
fgaz added 2 commits February 14, 2022 15:42
@fgaz
vengi-tools: 0.0.17 -> 0.0.18
85f9eb8 
(cherry picked from commit 7d87dad)
@fgaz
Revert "vengi-tools: remove failing roundtrip test"
b6b7406 
This reverts commit 50dae31.

(cherry picked from commit 97879bb)
@fgaz fgaz requested a review from jonringer as a code owner February 14, 2022 14:42
@fgaz fgaz changed the title [Backport release-21.11] vengi-tools: 0.0.14 -> 0.0.17 and related changes [Backport release-21.11] vengi-tools: 0.0.14 -> 0.0.18 and related changes Feb 14, 2022
@fgaz fgaz requested a review from Artturin February 15, 2022 13:00
@fgaz
Copy link
Member Author

fgaz commented Feb 21, 2022

/marvin opt-in

/status needs_rewiewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Feb 21, 2022

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot added the marvin This PR was reviewed by Marvin, a discontinued bot: https://github.com/timokau/marvin-mk2 label Feb 21, 2022
@fgaz

This comment was marked as duplicate.

Sign in to view
@fgaz
Copy link
Member Author

fgaz commented Feb 21, 2022

/status needs_reviewer

Too many "w"s 😅

@marvin-mk2 marvin-mk2 bot added the needs_reviewer (old Marvin label, do not use) label Feb 21, 2022
@marvin-mk2 marvin-mk2 bot requested a review from bennyandresen February 21, 2022 23:42
@marvin-mk2 marvin-mk2 bot added awaiting_reviewer (old Marvin label, do not use) and removed needs_reviewer (old Marvin label, do not use) labels Feb 21, 2022
jonringer
jonringer approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff looks goo to me, but would like a darwin user to confirm changes.

@marvin-mk2
Copy link

marvin-mk2 bot commented Feb 25, 2022

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be should be put back in the needs_reviewer queue in one day.

Note: This feature is currently broken. The bot will not actually change the status. If you see this message multiple times, please request a status change manually.

1 similar comment
@marvin-mk2
Copy link

marvin-mk2 bot commented Feb 28, 2022

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be should be put back in the needs_reviewer queue in one day.

Note: This feature is currently broken. The bot will not actually change the status. If you see this message multiple times, please request a status change manually.

@fgaz
Copy link
Member Author

fgaz commented Feb 28, 2022

/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added needs_reviewer (old Marvin label, do not use) awaiting_reviewer (old Marvin label, do not use) and removed awaiting_reviewer (old Marvin label, do not use) needs_reviewer (old Marvin label, do not use) labels Feb 28, 2022
@fgaz
Copy link
Member Author

fgaz commented Feb 28, 2022

@timokau for some reason marvin just undid its last action here #158116 (comment)

@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

@jonringer
Copy link
Contributor

ofborg built it

@jonringer jonringer merged commit 0ad8b80 into NixOS:release-21.11 Mar 2, 2022
@fgaz fgaz deleted the backport-156334-to-release-21.11 branch March 2, 2022 21:22
@timokau
Copy link
Member

timokau commented Mar 3, 2022

@fgaz that happens when marvin re-requests the same reviewer as before. Github does not show that in its UI. See timokau/marvin-mk2#86.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@Artturin Artturin Awaiting requested review from Artturin

@bennyandresen bennyandresen Awaiting requested review from bennyandresen

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes awaiting_reviewer (old Marvin label, do not use) marvin This PR was reviewed by Marvin, a discontinued bot: https://github.com/timokau/marvin-mk2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fgaz @turion @cole-h @jonringer @timokau