Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flutter319: drop #361667

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Conversation

RossComputerGuy
Copy link
Member

Things done

Drops Flutter 3.19 which doesn't support 64k page size, updates Rustdesk to 1.3.3.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 4, 2024
@ofborg ofborg bot requested review from Conni2461, dasJ and helsinki-Jo December 4, 2024 22:14
@dasJ
Copy link
Member

dasJ commented Dec 5, 2024

I started with the Rustdesk update as well and I only came to the same issue that your build is currently facing :/

@Bot-wxt1221
Copy link
Member

#380265

@Bot-wxt1221 Bot-wxt1221 mentioned this pull request Feb 9, 2025
13 tasks
@RossComputerGuy RossComputerGuy marked this pull request as ready for review February 11, 2025 02:32
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 361667


x86_64-linux

❌ 6 packages failed to build:
  • expidus.calculator
  • expidus.calculator.debug
  • expidus.calculator.pubcache
  • expidus.file-manager
  • expidus.file-manager.debug
  • expidus.file-manager.pubcache

aarch64-linux

❌ 6 packages failed to build:
  • expidus.calculator
  • expidus.calculator.debug
  • expidus.calculator.pubcache
  • expidus.file-manager
  • expidus.file-manager.debug
  • expidus.file-manager.pubcache

@RossComputerGuy
Copy link
Member Author

It's fine that those are borked, I'm going to fix them soon.

@RossComputerGuy RossComputerGuy merged commit 1cf7033 into NixOS:master Feb 11, 2025
39 checks passed
@RossComputerGuy RossComputerGuy deleted the feat/drop-flutter-3-19 branch February 11, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants