Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdesk-flutter: 1.3.2 ->1.3.7 #380265

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Conversation

Bot-wxt1221
Copy link
Member

@Bot-wxt1221 Bot-wxt1221 commented Feb 8, 2025

I'm tring to update flutter. Upstream use 3.22 but it's deleted now.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Bot-wxt1221
Copy link
Member Author

@emaryn You are right.

@Bot-wxt1221
Copy link
Member Author

OK. If we use flutter 3.24, it will try to fetch some dependencies. Anyway, it will build on 3.19 now.

@Bot-wxt1221 Bot-wxt1221 force-pushed the rustdesk branch 5 times, most recently from 9d36204 to 5c86369 Compare February 8, 2025 13:34
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5190

@Bot-wxt1221
Copy link
Member Author

nixpkgs-reviewd workflow finished

Status and logs: https://github.com/Bot-wxt1221/nixpkgs-reviewd/actions/runs/13216354798

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 380265


x86_64-linux

✅ 3 packages built:
  • rustdesk-flutter
  • rustdesk-flutter.debug
  • rustdesk-flutter.pubcache

@Bot-wxt1221 Bot-wxt1221 mentioned this pull request Feb 8, 2025
13 tasks
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 9, 2025
@Bot-wxt1221
Copy link
Member Author

Build date is not really removed now. DO NOT MERGE IT.

@Bot-wxt1221 Bot-wxt1221 changed the title rustdesk-flutter: 1.3.2 ->1.3.7 rustdesk-flutter: 1.3.2 ->1.3.7; flutter319: drop Feb 9, 2025
@nix-owners nix-owners bot requested a review from RossComputerGuy February 9, 2025 06:42
@Bot-wxt1221 Bot-wxt1221 changed the title rustdesk-flutter: 1.3.2 ->1.3.7; flutter319: drop rustdesk-flutter: 1.3.2 ->1.3.7 Feb 9, 2025
@Bot-wxt1221 Bot-wxt1221 requested a review from emaryn February 9, 2025 06:54
@Bot-wxt1221 Bot-wxt1221 force-pushed the rustdesk branch 2 times, most recently from 14682e7 to e4966f6 Compare February 9, 2025 09:55
@mweinelt mweinelt reopened this Feb 10, 2025
@RossComputerGuy
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 380265


aarch64-linux

❌ 3 packages failed to build:
  • rustdesk-flutter
  • rustdesk-flutter.debug
  • rustdesk-flutter.pubcache

@Bot-wxt1221
Copy link
Member Author

@RossComputerGuy Is that hash mismatch? Ofborg build it successfully.

@RossComputerGuy
Copy link
Member

error: 1 dependencies of derivation '/nix/store/2sazgs80789wdzlzfcf1qfjmgwnypn05-rustdesk-1.3.7.drv' failed to build
error: 1 dependencies of derivation '/nix/store/4541cg9l1df0l0jisl8nsbdp9vynh0yc-review-shell.drv' failed to build
┏━ 1 Errors:
 ⋮
┃        >     subcommand_func()
┃        >   File "/nix/store/d3af823bxi37syklw5hl4dvdxwqrvmjp-fetch-cargo-vendor-util/bin/fetch-…
┃        >     "create-vendor-staging": lambda: create_vendor_staging(lockfile_path=Path(sys.argv…
┃        >                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^…
┃        >   File "/nix/store/d3af823bxi37syklw5hl4dvdxwqrvmjp-fetch-cargo-vendor-util/bin/fetch-…
┃        >     cargo_lock_toml = load_toml(lockfile_path)
┃        >                       ^^^^^^^^^^^^^^^^^^^^^^^^
┃        >   File "/nix/store/d3af823bxi37syklw5hl4dvdxwqrvmjp-fetch-cargo-vendor-util/bin/fetch-…
┃        >     with open(path, "rb") as f:
┃        >          ^^^^^^^^^^^^^^^^
┃        > FileNotFoundError: [Errno 2] No such file or directory: 'Cargo.lock'
┃        For full logs, run 'nix log /nix/store/wwx7ndfld1zwzwg59qwyvf9sqnrylglx-rustdesk-1.3.7-v…

@Bot-wxt1221
Copy link
Member Author

@RossComputerGuy Now It will succeed.

@RossComputerGuy
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 380265


aarch64-linux

❌ 3 packages failed to build:
  • rustdesk-flutter
  • rustdesk-flutter.debug
  • rustdesk-flutter.pubcache

@RossComputerGuy
Copy link
Member

No logs are available...

@Bot-wxt1221
Copy link
Member Author

@RossComputerGuy What do you mean?

@RossComputerGuy
Copy link
Member

rustdesk-1.3.7-vendor-staging> buildPhase completed in 1 minutes 42 seconds
┏━ Dependency Graph:
┃       ┌─ ✔ rustdesk-1.3.7-vendor-staging ⏱ 2m22s
┃    ┌─ ⏸ rustdesk-1.3.7-vendor
┃ ┌─ ⏸ rustdesk-1.3.7
┃ ⏸ review-shell
┣━━━ Builds
┗━ ∑ ⏵ 0 │ ✔ 1 │ ⏸ 3 │ Finished at 18:37:02 after 2m30s

Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/380265

--------- Report for 'aarch64-linux' ---------
3 packages failed to build:
rustdesk-flutter rustdesk-flutter.debug rustdesk-flutter.pubcache

error: build log of '/nix/store/fdd2mgccha8idirqzfwj95n16kpijawg-rustdesk-1.3.7.drv^*' is not available
error: build log of '/nix/store/a0m8hlz2n74wkjklg0si5r435105njna-rustdesk-1.3.7' is not available
error: build log of '/nix/store/fdd2mgccha8idirqzfwj95n16kpijawg-rustdesk-1.3.7.drv^*' is not available
error: build log of '/nix/store/dzinrda1fns8n2g4l2mkvj0fh88czvid-rustdesk-1.3.7-debug' is not available
error: build log of '/nix/store/fdd2mgccha8idirqzfwj95n16kpijawg-rustdesk-1.3.7.drv^*' is not available
error: build log of '/nix/store/ynrz554cj1nbwmvggd7ychh94hi4piaj-rustdesk-1.3.7-pubcache' is not available
Posting result comment on https://github.com/NixOS/nixpkgs/pull/380265

@RossComputerGuy
Copy link
Member

I ran a nix build and got this:

buildPhase completed in 1 minutes 33 seconds
error: hash mismatch in fixed-output derivation '/nix/store/hw2416yncipx3wl2x2fjajrh2cz979bx-rustdesk-1.3.7-vendor-staging.drv':
         specified: sha256-1hipDx/xKOkqLj3JvguMZxseEBSSIwdJrT6LSOiEJp4=
            got:    sha256-05VQPrjmzSfWwxAPmeoNqmNxIDrosbFMjY6DqK0NLcY=
error: 1 dependencies of derivation '/nix/store/wjigh7nrx4703n89bnpjy2vwb9lqny7r-rustdesk-1.3.7-vendor.drv' failed to build
error: 1 dependencies of derivation '/nix/store/fdd2mgccha8idirqzfwj95n16kpijawg-rustdesk-1.3.7.drv' failed to build

@Bot-wxt1221
Copy link
Member Author

Bot-wxt1221 commented Feb 10, 2025

@RossComputerGuy I will try to rerun it. Or I just forget to inherit patches into it. Could you try again?

@RossComputerGuy
Copy link
Member

Alright, sweet. Spinning up a build, hopefully it should work this time.

@RossComputerGuy
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 380265


aarch64-linux

✅ 3 packages built:
  • rustdesk-flutter
  • rustdesk-flutter.debug
  • rustdesk-flutter.pubcache

@RossComputerGuy RossComputerGuy added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Feb 10, 2025
Copy link
Contributor

@gepbird gepbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested it by connecting to a remote desktop.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 380265


x86_64-linux

✅ 3 packages built:
  • rustdesk-flutter
  • rustdesk-flutter.debug
  • rustdesk-flutter.pubcache

Last few nits, feel free to ignore:

@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people and removed 12.approvals: 2 This PR was reviewed and approved by two reputable people labels Feb 10, 2025
@Bot-wxt1221
Copy link
Member Author

As you can see in ofborg. The hash doesn't change.

@RossComputerGuy RossComputerGuy merged commit 627f671 into NixOS:master Feb 11, 2025
27 checks passed
@RossComputerGuy
Copy link
Member

Thanks, I'll drop Flutter 3.19 tonight.

@gepbird gepbird mentioned this pull request Feb 11, 2025
13 tasks
@RossComputerGuy
Copy link
Member

Follow up in #361667

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants