-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdesk-flutter: 1.3.2 ->1.3.7 #380265
rustdesk-flutter: 1.3.2 ->1.3.7 #380265
Conversation
@emaryn You are right. |
OK. If we use flutter 3.24, it will try to fetch some dependencies. Anyway, it will build on 3.19 now. |
9d36204
to
5c86369
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5190 |
nixpkgs-reviewd workflow finishedStatus and logs: https://github.com/Bot-wxt1221/nixpkgs-reviewd/actions/runs/13216354798
|
Build date is not really removed now. DO NOT MERGE IT. |
14682e7
to
e4966f6
Compare
|
@RossComputerGuy Is that hash mismatch? Ofborg build it successfully. |
|
c320803
to
51492f4
Compare
@RossComputerGuy Now It will succeed. |
|
No logs are available... |
@RossComputerGuy What do you mean? |
|
I ran a nix build and got this:
|
@RossComputerGuy |
51492f4
to
004263b
Compare
Alright, sweet. Spinning up a build, hopefully it should work this time. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, tested it by connecting to a remote desktop.
nixpkgs-review
result
Generated using nixpkgs-review
.
Command: nixpkgs-review pr 380265
x86_64-linux
✅ 3 packages built:
- rustdesk-flutter
- rustdesk-flutter.debug
- rustdesk-flutter.pubcache
Last few nits, feel free to ignore:
aec2fe8
to
8a4fbb9
Compare
As you can see in ofborg. The hash doesn't change. |
Thanks, I'll drop Flutter 3.19 tonight. |
Follow up in #361667 |
I'm tring to update flutter. Upstream use 3.22 but it's deleted now.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.