[18.0][MIG] base_iso3166: Migration to 18.0 #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution. Please preserve commit history following technical method explained in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0. If the jump is between several versions, you have to modify the source branch in the main command to accommodate it to this circumstance. |
ClemRiviere
changed the title
=========================== ISO 3166 adaptation to Odoo =========================== This module adds some data specified by ISO 3166, specifically: * ISO 3166-1 alpha-3 (3-char) codes in countries * ISO 3166-1 numeric codes in countries * ISO 3166-3 formerly used codes in countries Check https://en.wikipedia.org/wiki/ISO_3166 for more info. Installation ============ This module requires the Python library pycountry >= 0.19 installed in the system. Known issues / Roadmap ====================== * Include 3166-2 country subdivision codes
Fix readme Fix manifest version Test coverage Delete author
With newer library versions, some countries are not found, so we have to protect that situation.
ClemRiviere
force-pushed
the
18.0-mig-base_iso3166
branch
from
dc7c727 to
dbdc8ed
Compare
|
Thanks a lot for your feedback, I've just refactored my branch following the migration method. |
ClemRiviere
changed the title
|
/ocabot migration base_iso3166 |
CarlosRoca13
approved these changes
Jan 23, 2025
|
ping @pedrobaeza |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 2383e47. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
This is my first contribution, do not hesitate to tell me if i am doing wrong and i will try to update
Thanks