[17.0][FIX] product_variant_sale_price: edit Sales Price

[gabe-grinspan]

There is an issue in 17.0 where the Sales Price field is not editable in the quick view page found by navigating to variants from a parent product page. This module makes it such that the field is separated between products and variants. It should be easy to modify this field without having to navigate to the variants list page and search.

I believe this worked in previous versions, as the code seems to indicate there was a purpose for clearing attrs but in Odoo 17, Odoo removed that attribute and replaced it with options. As it is, options has nothing to do with readonly in this case.

[gabriel-grinspan]

/ocabot merge

[OCA-git-bot]

Hi @gabriel-grinspan. Your command failed:

Required option bumpversion_mode for command merge. Possible values : major, minor, patch, nobump.

Ocabot commands

• ocabot merge major|minor|patch|nobump
• ocabot rebase
• ocabot migration {MODULE_NAME}

More information

• ocabot documentation
• OCA guidelines, specially the "Version Numbers" section.

[gabriel-grinspan]

/ocabot merge nobump

[OCA-git-bot]

Sorry @gabriel-grinspan you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

[gabriel-grinspan]

@HaraldPanten
Are you the right person to merge this? Please review.

[gabriel-grinspan]

@pedrobaeza

[pedrobaeza]

Follow commit message guidelines: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message

[pedrobaeza]

This change doesn't qualify for co-authorship, so remove it.

[gabriel-grinspan]

Do I get automatically added as a contributor, or do I have to manually update the README?

[pedrobaeza]

The commit attribution is already in GitHub, but for being explicitly in the README file, you have to add yourself in https://github.com/OCA/product-variant/blob/17.0/product_variant_sale_price/readme/CONTRIBUTORS.md and execute pre-commit

[pedrobaeza]

Do I merge as is for this time?

[gabriel-grinspan]

@pedrobaeza
This should be good now.

[gabriel-grinspan]

@pedrobaeza
I have amended my commit, updated the contributors, and run the pre-commit.

[pedrobaeza]

OK, let's fast-track as very clear:

/ocabot merge minor

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-363-by-pedrobaeza-bump-minor, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 008ef4f. Thanks a lot for contributing to OCA. ❤️