Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] sale_order_line_description #3070

Closed
wants to merge 46 commits into from
Closed

[16.0][MIG] sale_order_line_description #3070

wants to merge 46 commits into from

Conversation

MarioLM-23
Copy link

@MarioLM-23 MarioLM-23 commented Apr 11, 2024 •
edited
Loading

Last PR of migration module in open stage: #2450

tafaRU and others added 30 commits April 10, 2024 08:47
@tafaRU
Rename module to sale_order_line_description
99c36c5
[IMP] Update code to new api
fb3c7b3
@tafaRU
Update po files due to change name of module
ee6ae37
[IMP] sale_order_line_description: res_config => new api
a205929
@yvaucher
Add bug tracker link on README.rst
589dff3
@sysadminmatmoz
Slovene translations added
7f55079
@tafaRU
Get product aware of the language partner
1e8b1ae
@SimoRubi
[MIG] sale_order_line_description: Migration to 10.0
e94e5b1
@SimoRubi
[ADD] unit tests and minor changes
f7f7946
@oca-transbot
OCA Transbot updated translations from Transifex
d92076d
@oca-travis
[UPD] Update sale_order_line_description.pot
1ea43b4
@tafaRU
[IMP] sale_order_line_description: improve README file
b99c4ad
@cubells
[MIG] sale_order_line_description: Migration to 11.0
8d2b045
@OCA-git-bot
[UPD] README.rst
f629d8e
@oca-travis
[UPD] Update sale_order_line_description.pot
62adbf6
@oca-transbot
Update translation files
248d8d3 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-11.0/sale-workflow-11.0-sale_order_line_description
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-11-0/sale-workflow-11-0-sale_order_line_description/
@mohamedhagag
[12.0][MIG] sale_order_line_description: Migration to 12.0
7a31428
@mohamedhagag
squash! [12.0][MIG] sale_order_line_description: Migration to 12.0
290449d
@oca-travis
[UPD] Update sale_order_line_description.pot
6c7044f
@OCA-git-bot
[UPD] README.rst
177344e
@oca-transbot
Update translation files
d521ac3 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_line_description
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_line_description/
@liweijie0812
Added translation using Weblate (Chinese (Simplified))
ed2cde2
@liweijie0812
Translated using Weblate (Chinese (Simplified))
194c303 
Currently translated at 100.0% (7 of 7 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_line_description
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_line_description/zh_CN/
@maitaoriana
[IMP] sale_order_line_description: black, isort, prettier
c392e91
@kongrattapong
[MIG] sale_order_line_description: Migration to 13.0
caae4d4
@SimoneVagile
[MIG][14.0] sale_order_line_description
415c449
@oca-travis
[UPD] Update sale_order_line_description.pot
df86322
@OCA-git-bot
[UPD] README.rst
c5f6f02
@oca-transbot
Update translation files
9959612 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_order_line_description
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_line_description/
@marylla
Translated using Weblate (German)
43a0bf9 
Currently translated at 100.0% (7 of 7 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_order_line_description
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_line_description/de/
Yvesldff and others added 12 commits April 10, 2024 08:47
@Yvesldff
Translated using Weblate (French (France))
ad6dbaa 
Currently translated at 60.0% (6 of 10 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_order_line_description
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_line_description/fr_FR/
@emagdalenaC2i
[MIG] sale_order_line_description : Migration to 15.0
22caba4
[UPD] Update sale_order_line_description.pot
bae8fc3
@OCA-git-bot
[UPD] README.rst
d77b655
@OCA-git-bot
[IMP] update dotfiles [ci skip]
0b0c054
@mymage
Translated using Weblate (Italian)
6f361cf 
Currently translated at 14.2% (1 of 7 strings)

Translation: sale-workflow-15.0/sale-workflow-15.0-sale_order_line_description
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_order_line_description/it/
@Ivorra78
Translated using Weblate (Spanish)
2d57fe3 
Currently translated at 100.0% (7 of 7 strings)

Translation: sale-workflow-15.0/sale-workflow-15.0-sale_order_line_description
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_order_line_description/es/
@OCA-git-bot
[UPD] README.rst
ea5114d
@weblate
Update translation files
d1e9fdb 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-15.0/sale-workflow-15.0-sale_order_line_description
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_order_line_description/
[IMP] sale_order_line_description: pre-commit stuff
f9c0e2d
[MIG] sale_order_line_description: Migration to 16.0
d4baccf
@MarioLM-23
Merge branch 'OCA:16.0' into 16.0-mig-sale_order_line_description
636790e
@MarioLM-23 MarioLM-23 mentioned this pull request Apr 11, 2024
Open
100 tasks
@MarioLM-23 MarioLM-23 marked this pull request as ready for review April 15, 2024 06:58
@rousseldenis rousseldenis mentioned this pull request Apr 15, 2024
Closed
@rousseldenis
Copy link
Contributor

/ocabot migration sale_order_line_description

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Apr 15, 2024
rousseldenis
rousseldenis requested changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariobinhex Thanks for this.

Usually, it's fair to base your PR on other one to integrate the previous work (from #2450).

Moreover, his code was better than this one.

Could you change ? Thanks

sale_order_line_description/models/sale_order_line.py Outdated
@@ -8,8 +8,8 @@ class SaleOrderLine(models.Model):
_inherit = "sale.order.line"

@api.onchange("product_id")
def product_id_change(self):
res = super(SaleOrderLine, self).product_id_change()
def _onchange_product_id_warning(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use _compute_name() function instead.

sale_order_line_description/tests/test_sale.py Outdated
@@ -57,6 +58,7 @@ def test_check_sale_order_line_description(self):
sale_order_line = self.sale_order_line_model.with_user(self.user_1).create(
line_values.copy()
)
sale_order_line._onchange_product_id_warning()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After having changed to _compute_name() override, you don't need this anymore

Copy link
Author

@MarioLM-23 MarioLM-23 Apr 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rousseldenis Hi and thanks for the review
Pls check my changes and let me know if any further changes are needed.
Greetings!

AungKoKoLin1997
AungKoKoLin1997 reviewed Apr 22, 2024
View reviewed changes
sale_order_line_description/models/sale_order_line.py Outdated
class SaleOrderLine(models.Model):
_inherit = "sale.order.line"

@api.onchange("product_id")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be @api.depends.

Copy link
Author

@MarioLM-23 MarioLM-23 Apr 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AungKoKoLin1997 Thanks for the review
Done!

@MarioLM-23 MarioLM-23 requested a review from rousseldenis April 24, 2024 12:08
Jaimermaccione
Jaimermaccione approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@Jaimermaccione Jaimermaccione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Functional review on runboat.

tafaRU
tafaRU requested changes Dec 10, 2024
View reviewed changes
Copy link
Member

@tafaRU tafaRU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @MarioLM-23, thanks a lot for your work!

Could you please squash the following commits to only one?
image
According to https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0 at the end we're supposed to have:

  • [IMP] sale_order_line_description: black, isort, prettier
  • [MIG] sale_order_line_description: Migration to 16.0

Thank you in advance.

@tafaRU tafaRU mentioned this pull request Jan 7, 2025
Open
@tafaRU
Copy link
Member

tafaRU commented Jan 7, 2025

I close this in favor of #3523 where I keep @MarioLM-23's changes.
@Jaimermaccione @AungKoKoLin1997 @rousseldenis please add you review on the new PR. Thanks!

@tafaRU tafaRU closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tafaRU tafaRU tafaRU requested changes

@Jaimermaccione Jaimermaccione Jaimermaccione approved these changes

@rousseldenis rousseldenis Awaiting requested review from rousseldenis

@AungKoKoLin1997 AungKoKoLin1997 Awaiting requested review from AungKoKoLin1997

Assignees
No one assigned
Labels
migration needs review
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.