Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] sale_order_line_description #3523

Open
wants to merge 43 commits into
base: 16.0
Choose a base branch
from
Open

[16.0][MIG] sale_order_line_description #3523

wants to merge 43 commits into from
+1,684 −0

Conversation

tafaRU
Copy link
Member

@tafaRU tafaRU commented Jan 7, 2025

Superseeds #3070

tafaRU and others added 30 commits January 7, 2025 17:08
@tafaRU
Rename module to sale_order_line_description
f91386c
@tafaRU
[IMP] Update code to new api
d19d018
@tafaRU
Update po files due to change name of module
7298a51
@tafaRU
[IMP] sale_order_line_description: res_config => new api
1c410c1
@yvaucher @tafaRU
Add bug tracker link on README.rst
0058c92
@sysadminmatmoz @tafaRU
Slovene translations added
a6a1670
@tafaRU
Get product aware of the language partner
6e34928
@SimoRubi @tafaRU
[MIG] sale_order_line_description: Migration to 10.0
7fefa42
@SimoRubi @tafaRU
[ADD] unit tests and minor changes
6b563ea
@oca-transbot @tafaRU
OCA Transbot updated translations from Transifex
932519d
@oca-travis @tafaRU
[UPD] Update sale_order_line_description.pot
4a9375f
@tafaRU
[IMP] sale_order_line_description: improve README file
460428c
@cubells @tafaRU
[MIG] sale_order_line_description: Migration to 11.0
8c659df
@OCA-git-bot @tafaRU
[UPD] README.rst
c1bebaf
@oca-travis @tafaRU
[UPD] Update sale_order_line_description.pot
df1044e
@oca-transbot @tafaRU
Update translation files
6eb0df3 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-11.0/sale-workflow-11.0-sale_order_line_description
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-11-0/sale-workflow-11-0-sale_order_line_description/
@mohamedhagag @tafaRU
[12.0][MIG] sale_order_line_description: Migration to 12.0
43b98aa
@mohamedhagag @tafaRU
squash! [12.0][MIG] sale_order_line_description: Migration to 12.0
c590a34
@oca-travis @tafaRU
[UPD] Update sale_order_line_description.pot
ca275ff
@OCA-git-bot @tafaRU
[UPD] README.rst
23d7ad0
@oca-transbot @tafaRU
Update translation files
8331612 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_line_description
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_line_description/
@liweijie0812 @tafaRU
Added translation using Weblate (Chinese (Simplified))
958549a
@liweijie0812 @tafaRU
Translated using Weblate (Chinese (Simplified))
5d70220 
Currently translated at 100.0% (7 of 7 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_line_description
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_line_description/zh_CN/
@maitaoriana @tafaRU
[IMP] sale_order_line_description: black, isort, prettier
a694114
@kongrattapong @tafaRU
[MIG] sale_order_line_description: Migration to 13.0
ad1fb6c
@SimoneVagile @tafaRU
[MIG][14.0] sale_order_line_description
f794caa
@oca-travis @tafaRU
[UPD] Update sale_order_line_description.pot
5e9b201
@OCA-git-bot @tafaRU
[UPD] README.rst
5e02026
@oca-transbot @tafaRU
Update translation files
ae07360 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_order_line_description
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_line_description/
@marylla @tafaRU
Translated using Weblate (German)
009fca8 
Currently translated at 100.0% (7 of 7 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_order_line_description
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_line_description/de/
Yvesldff and others added 12 commits January 7, 2025 17:08
@Yvesldff @tafaRU
Added translation using Weblate (French (France))
dfadc32
@Yvesldff @tafaRU
Translated using Weblate (French)
9192d21 
Currently translated at 85.7% (6 of 7 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_order_line_description
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_line_description/fr/
@Yvesldff @tafaRU
Translated using Weblate (French (France))
cdd42d2 
Currently translated at 60.0% (6 of 10 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_order_line_description
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_line_description/fr_FR/
@emagdalenaC2i @tafaRU
[MIG] sale_order_line_description : Migration to 15.0
9dfb003
@tafaRU
[UPD] Update sale_order_line_description.pot
6d0a499
@OCA-git-bot @tafaRU
[UPD] README.rst
902b578
@OCA-git-bot @tafaRU
[IMP] update dotfiles [ci skip]
1e812b3
@mymage @tafaRU
Translated using Weblate (Italian)
cf35976 
Currently translated at 14.2% (1 of 7 strings)

Translation: sale-workflow-15.0/sale-workflow-15.0-sale_order_line_description
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_order_line_description/it/
@Ivorra78 @tafaRU
Translated using Weblate (Spanish)
79dbe90 
Currently translated at 100.0% (7 of 7 strings)

Translation: sale-workflow-15.0/sale-workflow-15.0-sale_order_line_description
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_order_line_description/es/
@OCA-git-bot @tafaRU
[UPD] README.rst
c5ba3e9
@weblate @tafaRU
Update translation files
a778ca6 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-15.0/sale-workflow-15.0-sale_order_line_description
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_order_line_description/
@tafaRU
[IMP] sale_order_line_description: pre-commit stuff
2df5c51
@tafaRU tafaRU mentioned this pull request Jan 7, 2025
Closed
@rousseldenis
Copy link
Contributor

/ocabot migration sale_order_line_description

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jan 7, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 7, 2025
Open
100 tasks
rousseldenis
rousseldenis reviewed Jan 7, 2025
View reviewed changes
sale_order_line_description/models/sale_order_line.py Outdated
@api.onchange("product_id")
def product_id_change(self):
res = super(SaleOrderLine, self).product_id_change()
@api.depends("product_id")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the depends as already defined in sale module.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thanks!

sale_order_line_description/models/sale_order_line.py Outdated
res = super(SaleOrderLine, self).product_id_change()
@api.depends("product_id")
def _compute_name(self):
res = super()._compute_name()
if not self.product_id: # pragma: no cover
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should change the function implementation to support multi recordset.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thanks!

@tafaRU tafaRU force-pushed the 16.0-mig-sale_order_line_description branch from 814f80d to e8abad9 Compare January 8, 2025 10:26
Jaimermaccione
Jaimermaccione reviewed Jan 8, 2025
View reviewed changes
Copy link
Contributor

@Jaimermaccione Jaimermaccione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially, everything seems to be working correctly. However, as mentioned above, if you add the product using the 'Add Multiple Products' function, it does not work as expected.

@tafaRU
Copy link
Member Author

tafaRU commented Jan 9, 2025

@Jaimermaccione thanks a lot for your review!

Concerning the following:

if you add the product using the 'Add Multiple Products' function, it does not work as expected.
it's due to in runboat in also installed https://github.com/OCA/sale-workflow/tree/16.0/sale_product_multi_add.

I suppose you have the the same behavior in previous versions (i.e 15.0).

I prefer not to add sale_product_multi_add as depends. The ideal solution to get two modules compatible should be to a create a module bridge. I'd now just add a ROADMAP section where to highlight the behavior.

@tafaRU
Copy link
Member Author

tafaRU commented Jan 10, 2025

@rousseldenis @Jaimermaccione could you please update your review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaimermaccione Jaimermaccione Jaimermaccione left review comments

@rousseldenis rousseldenis rousseldenis left review comments

Assignees
No one assigned
Labels
migration needs review
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.