[18.0][MIG] base_tier_validation: Migration to 18.0 #992

xaviedoanhduy · 2025-01-16T02:42:55Z

supersedes: #966

changes are follow up from old PR:

fix the icon on systray
fix the dymanic color alert on list reviewers
fix of not recalculating reviewCount when updating review requests (TierReviewService). don't use useState to calculate tierReviewCounter because the service will update services["mail.store"]
replaced old-style string interpolation with f-string and placeholder formatting
remove old jquery and replace with javascript available objects
optimize multi-company rule
replace deprecated output directives (t-esc)

bosd · 2025-01-16T04:34:48Z

Can you place your commits in a separate commit?
As there is also #990. Maybe we can cherry pick to merge these changes into there. If there is any difference.

xaviedoanhduy · 2025-01-16T04:51:09Z

Can you place your commits in a separate commit? As there is also #990. Maybe we can cherry pick to merge these changes into there. If there is any difference.

hi @bosd, that commit fixed the icon bug, but i consider that fix as part of PR Migration (because old PR is not yet merged). and author of this PR (#990) also mentioned we have duplicated work, you can read the conversation here: xaviedoanhduy#1 (comment)

bosd · 2025-01-16T07:11:07Z

Thanks for the clarification. I was getting a bit lost between the migration pr of this module.
Guess it was better to review this one.
Will do so when I have time.

Side note, on this one codecov is red.

ivantodorovich

Hey, thanks for taking care of this!

There are a few things that need to be corrected, IMO.
Could you check my remarks? 🙏🏻

Thanks!

ivantodorovich · 2025-01-16T14:09:58Z

base_tier_validation/models/res_users.py

+        review_groups = self.env["tier.review"].read_group(domain, ["model"], ["model"])
+        for review_group in review_groups:
+            model = review_group["model"]
+            Model = self.env[model]
+            reviews = self.env["tier.review"].search(review_group.get("__domain"))


💡 tip: This could probably be improved by leveraging the private _read_group method, and aggregating ['id:recordset'], and thus not needing to do a search afterwards

@ivantodorovich Good spot. that was on my mind as well.
There are some more places in the code of this module where the orm is flooded by searches from within a for loop.

The _read_group method was introduced in the orm in V17.
IMO that improvement could go into V17 and be forward ported here. Should not be blocking for this pr.

(But I've been told, there is even a more improved method in the V18 orm. But I don't know the details or have looked into that one.)

I think :recordset was added in 18.0.
In 17.0 a similar thing can be accomplished with :array_agg, and then browsing the list of ids.

FYI, _read_group and ir.recordset already exist in version 17.0, see: odoo/odoo#110737

and by the way I also applied the above code improvement from your suggestion, thank @ivantodorovich

@xaviedoanhduy Thanks!
Actually there are still some places in the code where a search is performed inside a for loop.
(Bad practice for performance.)
https://github.com/OCA/server-ux/pull/992/files#diff-7cca2e2b43a392c79d13759687633b9d88cfe56e6c2238b762e2c8d461690607R123-R124

Maybe you can attend to this, or put it on the roadmap.

FYI, _read_group and ir.recordset already exist in version 17.0, see: odoo/odoo#110737

Oh, indeed. Thanks!

base_tier_validation/models/tier_review.py

base_tier_validation/models/tier_validation.py

base_tier_validation/static/src/components/tier_review_widget/tier_review_widget.esm.js

miikanissi

Functional test looks good to me - no issues found

bosd

Thanks for your efforts and work on this: 👍

Functional test:

Colors are not showing in review bar as mentioned by @celm1990 in #990 (review)

xaviedoanhduy · 2025-01-21T01:14:06Z

Thanks for your efforts and work on this: 👍

Functional test:

Colors are not showing in review bar as mentioned by @celm1990 in #990 (review)

hi, color issue on reviewers list has been fixed. thanks for the tests

bosd

Funcitonal test. LGTM 👍

Non-blocking / nitpicking.
JS error/warning

UI can be improved a bit.

core:

sebalix · 2025-01-22T16:00:38Z

/ocabot migration base_tier_validation

…on and validate if possible.

…ation records

* able to restart validation * sudo() not needed anymore

Currently translated at 100.0% (143 of 143 strings) Translation: server-ux-17.0/server-ux-17.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_tier_validation/it/

Previous implementation was losing fields in some cases; new one properly merges dicts/tuples. This fixes odd "Missing field string information" errors in form-embedded lists. This cset also removes an obsolete `base_model_name` context key no longer used in Odoo 16. This cset adds a `test_get_view` test which checks for that `need_validation` field; it was failing with the previous impl. Fixes OCA#825.

Computed fields bypass `write`, so we need to override `_write` for that case. Also, the current value before the update needs to be fetched from the database because the new value is already set in the cache.

I just realized that a new author was added to the module during an improvement that merged the functionality of base_tier_validation_waiting. This was overlook during my review and not explicitly accepted. There have been many contributors adding new functionalities and this one was not specially big to be included as author.

…ejected = False

…Validation support

TierReview status "waiting" has been added and is the default. Modified the tier review reminder search domain to accommodate invalidate_cache() replaced with invalidate_recordset()

Currently translated at 100.0% (150 of 150 strings) Translation: server-ux-17.0/server-ux-17.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_tier_validation/it/

Co-authored-by: Do Anh Duy <[email protected]>

xaviedoanhduy · 2025-01-23T09:46:13Z

Funcitonal test. LGTM 👍

Non-blocking / nitpicking. JS error/warning ![image](https://private-user-images.githubusercontent.com/11499387/405347355-

hi @bosd, I'm not sure the error from your dev tool comes from this module.

I also took this opportunity to improve the interface a bit.

bosd · 2025-01-23T10:19:24Z

Thanks, If you want, you can include #991

celm1990

LGTM, just a minor change and let's go.
Additionally, please squash the administrative commits a bit. Thanks for the effort!

celm1990 · 2025-01-25T14:15:57Z

base_tier_validation/static/src/components/tier_review_widget/tier_review_widget.esm.js

+    onToggleCollapse(ev) {
+        const panelHeading = ev.currentTarget.closest(".panel-heading");
+        const collapseDiv = panelHeading.nextElementSibling.matches("div#collapse1")
+            ? panelHeading.nextElementSibling
+            : null;
+        if (!collapseDiv) return;
+        this.state.collapse = !this.state.collapse;
+        if (this.state.collapse) {
+            collapseDiv.style.display = "none";
+        } else {
+            collapseDiv.style.display = "block";
+        }
+    }


The first time you click the widget, it does not open; a second click is needed to collapse it. Please take a look. On the second attempt, it works fine, but if you refresh the view again, it doesn't work. I think the initial state might be related.

xaviedoanhduy mentioned this pull request Jan 16, 2025

[18.0][MIG] base_tier_validation: Migration to 18.0 #966

Closed

ivantodorovich suggested changes Jan 16, 2025

View reviewed changes

ivantodorovich mentioned this pull request Jan 16, 2025

[18.0][MIG] account_move_tier_validation: Migration to 18.0 OCA/account-invoicing#1830

Open

miikanissi approved these changes Jan 16, 2025

View reviewed changes

xaviedoanhduy force-pushed the 18.0-mig-base_tier_validation branch from bc507f3 to 3108668 Compare January 17, 2025 11:46

bosd suggested changes Jan 18, 2025

View reviewed changes

ivantodorovich approved these changes Jan 20, 2025

View reviewed changes

rjaraspearhead mentioned this pull request Jan 20, 2025

[18.0][MIG] base_tier_validation: Migration to 18.0 #990

Closed

xaviedoanhduy force-pushed the 18.0-mig-base_tier_validation branch from 3108668 to 60977bf Compare January 21, 2025 01:13

xaviedoanhduy requested a review from bosd January 21, 2025 01:19

bosd approved these changes Jan 21, 2025

View reviewed changes

OCA-git-bot added the approved label Jan 21, 2025

OCA-git-bot added this to the 18.0 milestone Jan 22, 2025

OCA-git-bot mentioned this pull request Jan 22, 2025

Migration to version 18.0 #948

Open

17 tasks

xaviedoanhduy force-pushed the 18.0-mig-base_tier_validation branch from 60977bf to 9aedf95 Compare January 23, 2025 09:42

LoisRForgeFlow added 10 commits January 23, 2025 16:42

[9.0][ADD] base_tier_validation

6390fa3

fix: blocking unneded records

400ff3b

[9.0][IMP] base_tier_validation: tries automatically request validati…

0a9e085

…on and validate if possible.

[9.0][IMP] base_tier_validation: filter out reviews not pending

1b884c9

make possible to filter by validated records

ff93690

allow to add exceptions for fields that can be written on under valid…

88616ee

…ation records

[9.0][IMP] base_tier_validation:

3c7f658

* able to restart validation * sudo() not needed anymore

[10.0][MIG] base_tier_validation

32acaca

[11.0][MIG] base_tier_validation

1f78aa7

[11.0][IMP] base_tier_validation: add tests

d65db79

mymage and others added 25 commits January 23, 2025 16:42

Translated using Weblate (Italian)

997c300

Currently translated at 100.0% (143 of 143 strings) Translation: server-ux-17.0/server-ux-17.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_tier_validation/it/

[BOT] post-merge updates

94f075a

[RFC]base_tier_validation: remove unused code

059fa32

[BOT] post-merge updates

4e5dfde

[IMP] base_tier_validation: support computed state field

7806c3a

Computed fields bypass `write`, so we need to override `_write` for that case. Also, the current value before the update needs to be fetched from the database because the new value is already set in the cache.

[BOT] post-merge updates

7ec46de

[BOT] post-merge updates

af4b1ae

[14.0][IMP] base_tier_validation: Add hook for state transition

949a472

[IMP] base_tier_validation: improve error message.

3468c47

[base_tier_validation][fix] Allow to search for validated=False and r…

3e23011

…ejected = False

[FIX] base_tier_validation: error on reviews after uninstalling Tier …

eccf5fd

…Validation support

[IMP] base_tier_validation: group_erp_manager can edit tier definitions.

572a82f

[14.0][IMP] add write possibility for reviewers

f14fb57

[IMP] base_tier_validation: Add reminder option

f1764e7

Fix base_tier_validation reminder option

55d2df4

[FIX] base_tier_validation: forward porting fixes

79375a1

TierReview status "waiting" has been added and is the default. Modified the tier review reminder search domain to accommodate invalidate_cache() replaced with invalidate_recordset()

[BOT] post-merge updates

fc74fc8

Translated using Weblate (Italian)

e657ebb

Currently translated at 100.0% (150 of 150 strings) Translation: server-ux-17.0/server-ux-17.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_tier_validation/it/

[IMP] base_tier_validation: add icon

03fd818

[BOT] post-merge updates

db12e46

[IMP] base_tier_validation: pre-commit auto fixes

c61cb15

[IMP] base_tier_validation: odoo upgrade_code fixes

1b2cb86

Co-authored-by: Do Anh Duy <[email protected]>

[MIG] base_tier_validation: Migration to 18.0

e7545d3

Co-authored-by: Do Anh Duy <[email protected]>

xaviedoanhduy force-pushed the 18.0-mig-base_tier_validation branch from 9aedf95 to e7545d3 Compare January 23, 2025 09:42

celm1990 suggested changes Jan 25, 2025

View reviewed changes

OCA-git-bot removed the approved label Jan 25, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[18.0][MIG] base_tier_validation: Migration to 18.0 #992

[18.0][MIG] base_tier_validation: Migration to 18.0 #992

xaviedoanhduy commented Jan 16, 2025 •

edited

Loading

bosd commented Jan 16, 2025

xaviedoanhduy commented Jan 16, 2025 •

edited

Loading

bosd commented Jan 16, 2025 •

edited

Loading

ivantodorovich left a comment

ivantodorovich Jan 16, 2025

bosd Jan 18, 2025

ivantodorovich Jan 20, 2025

xaviedoanhduy Jan 23, 2025

bosd Jan 23, 2025

ivantodorovich Jan 23, 2025

miikanissi left a comment

bosd left a comment

xaviedoanhduy commented Jan 21, 2025 •

edited

Loading

bosd left a comment

sebalix commented Jan 22, 2025

xaviedoanhduy commented Jan 23, 2025

bosd commented Jan 23, 2025

celm1990 left a comment

celm1990 Jan 25, 2025

[18.0][MIG] base_tier_validation: Migration to 18.0 #992

Are you sure you want to change the base?

[18.0][MIG] base_tier_validation: Migration to 18.0 #992

Conversation

xaviedoanhduy commented Jan 16, 2025 • edited Loading

bosd commented Jan 16, 2025

xaviedoanhduy commented Jan 16, 2025 • edited Loading

bosd commented Jan 16, 2025 • edited Loading

ivantodorovich left a comment

Choose a reason for hiding this comment

ivantodorovich Jan 16, 2025

Choose a reason for hiding this comment

bosd Jan 18, 2025

Choose a reason for hiding this comment

ivantodorovich Jan 20, 2025

Choose a reason for hiding this comment

xaviedoanhduy Jan 23, 2025

Choose a reason for hiding this comment

bosd Jan 23, 2025

Choose a reason for hiding this comment

ivantodorovich Jan 23, 2025

Choose a reason for hiding this comment

miikanissi left a comment

Choose a reason for hiding this comment

bosd left a comment

Choose a reason for hiding this comment

xaviedoanhduy commented Jan 21, 2025 • edited Loading

bosd left a comment

Choose a reason for hiding this comment

sebalix commented Jan 22, 2025

xaviedoanhduy commented Jan 23, 2025

bosd commented Jan 23, 2025

celm1990 left a comment

Choose a reason for hiding this comment

celm1990 Jan 25, 2025

Choose a reason for hiding this comment

xaviedoanhduy commented Jan 16, 2025 •

edited

Loading

xaviedoanhduy commented Jan 16, 2025 •

edited

Loading

bosd commented Jan 16, 2025 •

edited

Loading

xaviedoanhduy commented Jan 21, 2025 •

edited

Loading