[18.0][MIG] base_tier_validation: Migration to 18.0 #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please help test the functionality now? |
|
@rjaraspearhead Thanks, will review this one. Can you drop the merge commit? |
bosd
suggested changes
Jan 15, 2025
miikanissi
approved these changes
Jan 15, 2025
celm1990
suggested changes
Jan 15, 2025
There was a problem hiding this comment.
Thank you for your efforts. I have attached a video demonstrating the visual issues we are observing. While the functionality is working as expected, we would appreciate it if you could review the UI.
V17
https://drive.google.com/file/d/11NkRgIxCA4rivFy_orHTK2lTBXDC5MbZ/view?usp=sharing
V18
https://drive.google.com/file/d/1FoB7xZe-syZBPlR6f6ciA296-w3g0Ymj/view?usp=sharing
Comment on lines
+10
to
+19
| this.busService.subscribe("base.tier.validation/updated", (payload) => { | ||
| if (payload.review_created) { | ||
| this.store.tierReviewCounter++; | ||
| } | ||
| if (payload.review_deleted) { | ||
| this.store.tierReviewCounter--; | ||
| } | ||
| }); | ||
| this.busService.start(); |
There was a problem hiding this comment.
Please check this issue; real-time updates are not working. Please review the video where it works fine in V17.
Comment on lines
52
to
84
| <t | ||
| t-if="review.status == 'waiting'" | ||
| t-set="status_class" | ||
| t-value="'text-muted'" | ||
| /> | ||
| <t | ||
| t-if="review.status == 'pending'" | ||
| t-set="status_class" | ||
| t-value="" | ||
| /> | ||
| <t | ||
| t-if="review.status == 'approved'" | ||
| t-set="status_class" | ||
| t-value="'alert-success'" | ||
| /> | ||
| <t | ||
| t-if="review.status == 'rejected'" | ||
| t-set="status_class" | ||
| t-value="'alert-danger'" | ||
| /> | ||
| <tr t-att-class="status_class"> |
There was a problem hiding this comment.
These styles aren't applied correctly; please take a look.
…on and validate if possible.
* able to restart validation * sudo() not needed anymore
and reject can be hidden according to this computed field.
… and who asks for reviews in new fields 'done_by' and 'requested_by'.
fixup and extend tests [ADD] systray icon for pending reviews [FIX] Remove python safe_eval [ADD] base_tier_validation_formula and migration scripts [ADD] widget domain and python expression to define reviewer in tier definition [ADD] auto updating of systray icon counter [ADD] validation date field [ADD] review widget dropdown menu
…reviews' name and state correctly translated.
* using similar approach to activities has already benn addressed. * add a new point explaining review tooltip improvement possibilities.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-ux-17.0/server-ux-17.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_tier_validation/
Currently translated at 100.0% (143 of 143 strings) Translation: server-ux-17.0/server-ux-17.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_tier_validation/it/
Previous implementation was losing fields in some cases; new one properly merges dicts/tuples. This fixes odd "Missing field string information" errors in form-embedded lists. This cset also removes an obsolete `base_model_name` context key no longer used in Odoo 16. This cset adds a `test_get_view` test which checks for that `need_validation` field; it was failing with the previous impl. Fixes OCA#825.
Computed fields bypass `write`, so we need to override `_write` for that case. Also, the current value before the update needs to be fetched from the database because the new value is already set in the cache.
I just realized that a new author was added to the module during an improvement that merged the functionality of base_tier_validation_waiting. This was overlook during my review and not explicitly accepted. There have been many contributors adding new functionalities and this one was not specially big to be included as author.
…Validation support
TierReview status "waiting" has been added and is the default. Modified the tier review reminder search domain to accommodate invalidate_cache() replaced with invalidate_recordset()
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-ux-17.0/server-ux-17.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_tier_validation/
Currently translated at 100.0% (150 of 150 strings) Translation: server-ux-17.0/server-ux-17.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_tier_validation/it/
rjaraspearhead
force-pushed
the
18.0-mig-base_tier_validation
branch
from
f43070d to
16735b3
Compare
|
I am canceling this PR because it is being worked on in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes #966
This PR enhances the menu icon and the display of items pending approval.