[18.0][MIG] base_tier_validation: Migration to 18.0 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xaviedoanhduy
force-pushed
the
18.0-mig-base_tier_validation
branch
3 times, most recently
from
0a8050b to
bc507f3
Compare
|
@xaviedoanhduy Your changes are better, and I could cancel my PR since we were both working on the same migration. |
hi @rjaraspearhead, I have created PR on OCA side ( |
chaule97
approved these changes
Jan 16, 2025
xaviedoanhduy
force-pushed
the
18.0-mig-base_tier_validation
branch
2 times, most recently
from
3108668 to
60977bf
Compare
xaviedoanhduy
force-pushed
the
18.0-mig-base_tier_validation
branch
from
60977bf to
9aedf95
Compare
…on and validate if possible.
* able to restart validation * sudo() not needed anymore
and reject can be hidden according to this computed field.
… and who asks for reviews in new fields 'done_by' and 'requested_by'.
fixup and extend tests [ADD] systray icon for pending reviews [FIX] Remove python safe_eval [ADD] base_tier_validation_formula and migration scripts [ADD] widget domain and python expression to define reviewer in tier definition [ADD] auto updating of systray icon counter [ADD] validation date field [ADD] review widget dropdown menu
Silence the warning: Two fields (model_name, model_id) of tier.validation.exception() have the same label: Model. [Modules: base_tier_validation and base_tier_validation]
Currently translated at 100.0% (143 of 143 strings) Translation: server-ux-17.0/server-ux-17.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_tier_validation/it/
Previous implementation was losing fields in some cases; new one properly merges dicts/tuples. This fixes odd "Missing field string information" errors in form-embedded lists. This cset also removes an obsolete `base_model_name` context key no longer used in Odoo 16. This cset adds a `test_get_view` test which checks for that `need_validation` field; it was failing with the previous impl. Fixes OCA#825.
Computed fields bypass `write`, so we need to override `_write` for that case. Also, the current value before the update needs to be fetched from the database because the new value is already set in the cache.
I just realized that a new author was added to the module during an improvement that merged the functionality of base_tier_validation_waiting. This was overlook during my review and not explicitly accepted. There have been many contributors adding new functionalities and this one was not specially big to be included as author.
…Validation support
TierReview status "waiting" has been added and is the default. Modified the tier review reminder search domain to accommodate invalidate_cache() replaced with invalidate_recordset()
Currently translated at 100.0% (150 of 150 strings) Translation: server-ux-17.0/server-ux-17.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_tier_validation/it/
Co-authored-by: Do Anh Duy <[email protected]>
Co-authored-by: Do Anh Duy <[email protected]>
xaviedoanhduy
force-pushed
the
18.0-mig-base_tier_validation
branch
from
9aedf95 to
e7545d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
take over PR: OCA#966
changes are follow up from old PR:
TierReviewService). don't use useState to calculate tierReviewCounter because the service will updateservices["mail.store"]f-stringand placeholder formattingt-esc)