Jatin get profile images from website #1116
Conversation
|
Code work great, but I don't think it is necessary to introduce an extra dependency ( Asides from the code part, I wasn't quite sure why this functionality was needed since we already had the functionality to set avatar in the app. I've commented on the bugs docs for the same issue. |
Removed puppeteer, using fetch to reduce load on the server. Please review again. |
Hritvik111
added
the
High Priority - Please Review First
JatinAgrawal94
force-pushed
the
jatin_get_profile_images_from_website
branch
from
dd0c2db to
840e7b9
Compare
| const getProfileImagesFromWebsite= async () => { | ||
| try { | ||
| // Fetch the webpage | ||
| const response = await axios.get("https://www.onecommunityglobal.org/team"); |
There was a problem hiding this comment.
Consider adding timeout and retry logic. Without timeout and retry logic, if the network requests fail or hang, it could cause the application to become unresponsive.
| return false; | ||
| } | ||
|
|
||
| async function imageUrlToPngBase64(url) { |
There was a problem hiding this comment.
Consider adding image size limit or image compression to ensure large size images won't slow down the server significantly.
| }); | ||
| var users=await userProfile.find({'isActive':true},"firstName lastName email profilePic suggestedProfilePics") | ||
|
|
||
| users.map(async(u)=>{ |
There was a problem hiding this comment.
Your current implementation using map with async callbacks. I think this might lead to race conditions, since it doesn't wait for all promises to resolve. I would suggest using Promise.all to properly handle multiple asynchronous operations.
Description
Related PRS (if any):
To test this backend PR you need to checkout the #2714 frontend PR.
Main changes explained:
usercontroller.jsfor removing and updating profile images.userhelper.jsfor getting images from website.suggestedProfilePicsto store images from website.How to test:
npm installand...to run this PR locallynpm run buildandnpm start.Screenshots or videos of changes:
profile_images.mp4